<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div>Can you try this patch? </div><div> </div><div>diff --git a/common/canvas_base.c b/common/canvas_base.c index 957f887..ae064ca 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -438,9 +438,9 @@ static pixman_image_t *canvas_get_quic(CanvasBase *canvas, SpiceImage *image, //#define DUMP_JPEG #ifdef DUMP_JPEG -static int jpeg_id = 0; -static void dump_jpeg(uint8_t* data, int data_size) +static void dump_jpeg(SpiceChunks* data, uint32_t data_size) { + static uint32_t jpeg_id = 0; char file_str[200]; uint32_t id = ++jpeg_id; @@ -455,9 +455,13 @@ static void dump_jpeg(uint8_t* data, int data_size) return; } - fwrite(data, 1, data_size, f); + for (uint32_t n = 0; n < data->num_chunks; ++n) { + fwrite(data->chunk[n].data, 1, data->chunk[n].len, f); + } fclose(f); } +#else +static inline void dump_jpeg(SpiceChunks* data, uint32_t data_size) {} #endif static pixman_image_t *canvas_get_jpeg(CanvasBase *canvas, SpiceImage *image) @@ -486,9 +490,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase *canvas, SpiceImage *image) canvas->jpeg->ops->decode(canvas->jpeg, dest, stride, SPICE_BITMAP_FMT_32BIT); -#ifdef DUMP_JPEG dump_jpeg(image->u.jpeg.data, image->u.jpeg.data_size); -#endif return surface; } @@ -665,9 +667,7 @@ static pixman_image_t *canvas_get_jpeg_alpha(CanvasBase *canvas, SpiceImage *ima } lz_decode(lz_data->lz, LZ_IMAGE_TYPE_XXXA, decomp_alpha_buf); -#ifdef DUMP_JPEG dump_jpeg(image->u.jpeg_alpha.data, image->u.jpeg_alpha.jpeg_size); -#endif return surface; } </div><div>Frediano </div><div> </div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><style></style><div class="WordSection1">Fix bug. 发送自 Windows 10 版<a href="https://go.microsoft.com/fwlink/?LinkId=550986" target="_blank">邮件</a>应用 <div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">发件人: <a href="mailto:fziglio@redhat.com" target="_blank">Frediano Ziglio</a> 发送时间: 2018年6月20日 18:32 收件人: <a href="mailto:KunMing.Xie@hotmail.com" target="_blank">谢 昆明</a> 抄送: <a href="mailto:spice-devel@lists.freedesktop.org" target="_blank">spice-devel@lists.freedesktop.org</a>; <a href="mailto:cfergeau@redhat.com" target="_blank">Christophe Fergeau</a> 主题: Re: [Spice-devel] 答复: how to open jpg binary file (/tmp/spice_dump/x.jpg)?</div> Yes. It is some spice code which is calling dump_jpeg. After apply this patch, jpeg file can be open by eog. <div>The call is correct. What is wrong is dump_jpeg which should handle all chunks and not assume that pointer</div><div>is raw data.</div><div>Thanks for the report.</div><div>What are you trying to do dumping jpeg images?</div><div> </div><div>Frediano</div><div> </div><blockquote style="border:none;border-left:solid #1010FF 1.5pt;padding:0cm 0cm 0cm 4.0pt;margin-left:3.75pt;margin-top:5.0pt;margin-bottom:5.0pt">发送自 Windows 10 版<a href="https://go.microsoft.com/fwlink/?LinkId=550986" target="_blank">邮件</a>应用 <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">发件人: <a href="mailto:cfergeau@redhat.com" target="_blank">Christophe Fergeau</a> 发送时间: 2018年6月20日 17:28 收件人: <a href="mailto:KunMing.Xie@hotmail.com" target="_blank">谢 昆明</a> 抄送: <a href="mailto:spice-devel@lists.freedesktop.org" target="_blank">spice-devel@lists.freedesktop.org</a> 主题: Re: [Spice-devel] how to open jpg binary file (/tmp/spice_dump/x.jpg)?</div> Hey, On Wed, Jun 20, 2018 at 02:14:54AM +0000, 谢昆明 wrote:> Hey guys. I have dump some jpg file, but I can’t open it with eog. I don't understand how this relates to spice? Is this some spice codewhich is calling dump_jpeg? Christophe > > > static int jpeg_id = 0;> static void dump_jpeg(uint8_t* data, int data_size)> {> char file_str[200];> uint32_t id = ++jpeg_id;> > #ifdef WIN32> sprintf(file_str, "c:\\tmp\\spice_dump\\%u.jpg", id);> #else> sprintf(file_str, "/tmp/spice_dump/%u.jpg", id);> #endif> > FILE *f = fopen(file_str, "wb");> if (!f) {> return;> }> > fwrite(data, 1, data_size, f);> fclose(f);> }> > > 发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用</blockquote>> </div></blockquote><div> </div></div></body></html>