<div dir="ltr"><div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On Tue, Sep 18, 2018 at 1:52 PM, Marc-André Lureau <<a href="mailto:marcandre.lureau@gmail.com" target="_blank">marcandre.lureau@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi On Mon, Sep 17, 2018 at 5:24 PM Yuri Benditovich <<a href="mailto:yuri.benditovich@daynix.com">yuri.benditovich@daynix.com</a>> wrote: > > This series of patches adds ability to share ISO files or > local CD devices with guest system using USB redirection > by emulation of USB CD device. and DVD, I guess. How much of this "new" emulation code overlaps with existing USB code in QEMU ? Gerd, as QEMU USB storage maintainer, your help reviewing this code is very much welcome! > For more information see commit comment of patch 13. > > Currently both new usb device widget and old one > present in the code and the old one can be selected > by configuration. If required, old usb device widget > will be removed in separate commit > > Changes from v3: > Single commit with all new files split to 12 patches > to make patch review easier > It would help review iterations (at least for CI) if you could hold your WIP tree on <a href="http://gitlab.freedesktop.org" rel="noreferrer" target="_blank">gitlab.freedesktop.org</a></blockquote><div> </div><div>Maintained under <a href="https://gitlab.freedesktop.org/yuri_benditovich/spice-gtk/commits/cd-sharing">https://gitlab.freedesktop.org/yuri_benditovich/spice-gtk/commits/cd-sharing</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> thanks <div><div class="gmail-h5"> > Yuri Benditovich (13): > cd-sharing: add cd-device header file > cd-sharing: implement cd-device for Linux > cd-sharing: implement cd-device for Windows > cd-sharing: add header file with SCSI definitions > cd-sharing: introduce header file for SCSI device parameters > cd-sharing: add interface definition for SCSI device > cd-sharing: add implementation of SCSI device > cd-sharing: added interface file for USB mass storage device > cd-sharing: added implementation of USB mass storage device > cd-charing: added interface definition for USB backend device > cd-sharing: added implementation of USB backend > cd-sharing: implementation of new USB widget > cd-sharing: Implementation of CD sharing feature > > <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 27 + > src/Makefile.am | 15 +- > src/cd-device-linux.c | 137 ++ > src/cd-device-win.c | 193 +++ > src/cd-device.h | 40 + > src/cd-scsi-dev-params.h | 52 + > src/cd-scsi.c | 2765 +++++++++++++++++++++++++++++++++++++++++ > src/cd-scsi.h | 122 ++ > src/cd-usb-bulk-msd.c | 555 +++++++++ > src/cd-usb-bulk-msd.h | 134 ++ > src/channel-usbredir-priv.h | 9 +- > src/channel-usbredir.c | 267 ++-- > src/map-file | 9 + > src/scsi-constants.h | 324 +++++ > src/spice-option.c | 15 + > src/usb-backend-common.c | 2015 ++++++++++++++++++++++++++++++ > src/usb-backend.h | 112 ++ > src/usb-device-manager-priv.h | 5 +- > src/usb-device-manager.c | 743 +++++++---- > src/usb-device-manager.h | 107 +- > src/usb-device-redir-widget.c | 2065 ++++++++++++++++++++++++++++++ > src/usb-device-widget.c | 5 + > src/usbutil.c | 52 +- > src/usbutil.h | 5 +- > src/win-usb-dev.c | 66 +- > src/win-usb-dev.h | 2 + > 26 files changed, 9321 insertions(+), 520 deletions(-) > create mode 100644 src/cd-device-linux.c > create mode 100644 src/cd-device-win.c > create mode 100644 src/cd-device.h > create mode 100644 src/cd-scsi-dev-params.h > create mode 100644 src/cd-scsi.c > create mode 100644 src/cd-scsi.h > create mode 100644 src/cd-usb-bulk-msd.c > create mode 100644 src/cd-usb-bulk-msd.h > create mode 100644 src/scsi-constants.h > create mode 100644 src/usb-backend-common.c > create mode 100644 src/usb-backend.h > create mode 100644 src/usb-device-redir-widget.c > > -- > 2.9.4 > </div></div>> _______________________________________________ > Spice-devel mailing list > <a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a> -- Marc-André Lureau </blockquote></div> </div></div></div>