<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 18, 2018 at 7:04 PM, Yuri Benditovich <span dir="ltr"><<a href="mailto:yuri.benditovich@daynix.com" target="_blank">yuri.benditovich@daynix.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Tue, Sep 18, 2018 at 1:52 PM, Marc-André Lureau <span dir="ltr"><<a href="mailto:marcandre.lureau@gmail.com" target="_blank">marcandre.lureau@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi<br>
<span class="m_8399672413753192347gmail-"><br>
On Mon, Sep 17, 2018 at 5:24 PM Yuri Benditovich<br>
<<a href="mailto:yuri.benditovich@daynix.com" target="_blank">yuri.benditovich@daynix.com</a>> wrote:<br>
><br>
> This series of patches adds ability to share ISO files or<br>
> local CD devices with guest system using USB redirection<br>
> by emulation of USB CD device.<br>
<br>
</span>and DVD, I guess.<br>
<br>
How much of this "new" emulation code overlaps with existing USB code in QEMU ?<br></blockquote></span></div></div></div></div></blockquote><div><br></div><div>AFAIU, no such overlapping. QEMU works with guest usbredir, spice-gtk with host (libusb) and</div><div>parser (cd)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Gerd, as QEMU USB storage maintainer, your help reviewing this code is<br>
very much welcome!<br>
<span class="m_8399672413753192347gmail-"><br>
> For more information see commit comment of patch 13.<br>
><br>
> Currently both new usb device widget and old one<br>
> present in the code and the old one can be selected<br>
> by configuration. If required, old usb device widget<br>
> will be removed in separate commit<br>
><br>
> Changes from v3:<br>
> Single commit with all new files split to 12 patches<br>
> to make patch review easier<br>
><br>
<br>
</span>It would help review iterations (at least for CI) if you could hold<br>
your WIP tree on <a href="http://gitlab.freedesktop.org" rel="noreferrer" target="_blank">gitlab.freedesktop.org</a></blockquote><div><br></div></span><div>Maintained under <a href="https://gitlab.freedesktop.org/yuri_benditovich/spice-gtk/commits/cd-sharing" target="_blank">https://gitlab.<wbr>freedesktop.org/yuri_<wbr>benditovich/spice-gtk/commits/<wbr>cd-sharing</a></div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
thanks<br>
<div><div class="m_8399672413753192347gmail-h5"><br>
> Yuri Benditovich (13):<br>
> cd-sharing: add cd-device header file<br>
> cd-sharing: implement cd-device for Linux<br>
> cd-sharing: implement cd-device for Windows<br>
> cd-sharing: add header file with SCSI definitions<br>
> cd-sharing: introduce header file for SCSI device parameters<br>
> cd-sharing: add interface definition for SCSI device<br>
> cd-sharing: add implementation of SCSI device<br>
> cd-sharing: added interface file for USB mass storage device<br>
> cd-sharing: added implementation of USB mass storage device<br>
> cd-charing: added interface definition for USB backend device<br>
> cd-sharing: added implementation of USB backend<br>
> cd-sharing: implementation of new USB widget<br>
> cd-sharing: Implementation of CD sharing feature<br>
><br>
> <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 27 +<br>
> src/Makefile.am | 15 +-<br>
> src/cd-device-linux.c | 137 ++<br>
> src/cd-device-win.c | 193 +++<br>
> src/cd-device.h | 40 +<br>
> src/cd-scsi-dev-params.h | 52 +<br>
> src/cd-scsi.c | 2765 ++++++++++++++++++++++++++++++<wbr>+++++++++++<br>
> src/cd-scsi.h | 122 ++<br>
> src/cd-usb-bulk-msd.c | 555 +++++++++<br>
> src/cd-usb-bulk-msd.h | 134 ++<br>
<br>
<br>
> src/channel-usbredir-priv.h | 9 +-<br>
> src/channel-usbredir.c | 267 ++--<br>
> src/map-file | 9 +<br>
> src/scsi-constants.h | 324 +++++<br>
> src/spice-option.c | 15 +<br>
> src/usb-backend-common.c | 2015 ++++++++++++++++++++++++++++++<br>
> src/usb-backend.h | 112 ++<br>
> src/usb-device-manager-priv.h | 5 +-<br>
> src/usb-device-manager.c | 743 +++++++----<br>
> src/usb-device-manager.h | 107 +-<br>
> src/usb-device-redir-widget.c | 2065 ++++++++++++++++++++++++++++++<br>
> src/usb-device-widget.c | 5 +<br>
> src/usbutil.c | 52 +-<br>
> src/usbutil.h | 5 +-<br>
> src/win-usb-dev.c | 66 +-<br>
> src/win-usb-dev.h | 2 +<br>
> 26 files changed, 9321 insertions(+), 520 deletions(-)<br>
> create mode 100644 src/cd-device-linux.c<br>
> create mode 100644 src/cd-device-win.c<br>
> create mode 100644 src/cd-device.h<br>
> create mode 100644 src/cd-scsi-dev-params.h<br>
> create mode 100644 src/cd-scsi.c<br>
> create mode 100644 src/cd-scsi.h<br>
> create mode 100644 src/cd-usb-bulk-msd.c<br>
> create mode 100644 src/cd-usb-bulk-msd.h<br>
> create mode 100644 src/scsi-constants.h<br>
> create mode 100644 src/usb-backend-common.c<br>
> create mode 100644 src/usb-backend.h<br>
> create mode 100644 src/usb-device-redir-widget.c<br>
><br>
> --<br>
> 2.9.4<br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> Spice-devel mailing list<br>
> <a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.<wbr>org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/spice-devel</a><br>
<br>
<br>
<br>
--<br>
Marc-André Lureau<br>
</blockquote></div></div></div><br></div></div></div>
</blockquote></div><br></div></div>