<div dir="ltr">No problem, the point is to solve this somehow and allow the build of mingw </div> <div class="gmail_quote"><div dir="ltr">On Mon, Oct 1, 2018 at 10:57 AM Marc-André Lureau <<a href="mailto:marcandre.lureau@gmail.com">marcandre.lureau@gmail.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi On Sun, Sep 30, 2018 at 7:10 PM Yuri Benditovich <<a href="mailto:yuri.benditovich@daynix.com" target="_blank">yuri.benditovich@daynix.com</a>> wrote: > > Currently mingw build of qmp-helper fails under mingw > due to undefined memmem function. > Disabling it for mingw till better solution. > > Signed-off-by: Yuri Benditovich <<a href="mailto:yuri.benditovich@daynix.com" target="_blank">yuri.benditovich@daynix.com</a>> nack, by compiling out public symbols, the library will have a different ABI. Christophe proposed to replace memmem with g_ststr_len() instead. > --- > <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 3 +++ > src/qmp-port.c | 7 +++++++ > 2 files changed, 10 insertions(+) > > diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> > index e686d76..29a3cfa 100644 > --- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> > +++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> > @@ -59,6 +59,9 @@ esac > AC_MSG_RESULT([$os_win32]) > AM_CONDITIONAL([OS_WIN32],[test "$os_win32" = "yes"]) > > +AS_IF([test "$os_win32" = "no"], > + AC_DEFINE([USE_JSON], [1], [Define if supporting JSON])) > + > AC_MSG_CHECKING([for native macOS]) > case "$host_os" in > *darwin*) > diff --git a/src/qmp-port.c b/src/qmp-port.c > index c91f967..b39eb04 100644 > --- a/src/qmp-port.c > +++ b/src/qmp-port.c > @@ -22,6 +22,8 @@ > #include <json-glib/json-glib.h> > #include "spice-client.h" > > +#if USE_JSON > + > /** > * SECTION:qmp-port > * @short_description: QMP port helper > @@ -592,3 +594,8 @@ spice_qmp_port_query_status_finish(SpiceQmpPort *self, > > return g_task_propagate_pointer(G_TASK(result), error); > } > + > +#else > +/* public procedures for compatibility */ > + > +#endif /* USE_JSON*/ > -- > 2.17.0 > > _______________________________________________ > Spice-devel mailing list > <a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a> -- Marc-André Lureau </blockquote></div>