<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><br></div><div>Hi again</div><div><br></div><div>El lun, 24-09-2018 a las 08:25 +0200, Javier Celaya escribió:</div><blockquote style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Hi</div><div><br></div><div>El mié, 19-09-2018 a las 15:30 +0200, Victor Toso escribió:</div><blockquote style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>Hi,</pre><pre><br></pre><pre>On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote:</pre><pre>Hi, sorry for the late response, I was on holidays</pre><pre>El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió:</pre><pre>On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya<javier.celaya@flexvdi.</pre><pre>com> wrote:The main channel reference d->main of SpiceWidget is</pre><pre>initialized onconstruction. However, it is used a couple of times</pre><pre>before that momentwhile setting the default values of some</pre><pre>properties, like resize-guest.This results in some annoying critical</pre><pre>log messages. This commit makessure that d->main is not used in such</pre><pre>situations if it is NULL.</pre><pre>Could you provide a reproducer of such warnings? I don't remember</pre><pre>seeing one.</pre><pre><br></pre><pre>I see them each time I connect to a Spice session with spicy. Follow</pre><pre>me:</pre><pre>- These warnings appear because d->main is NULL.</pre><pre>- d->main is set in spice-widget.c:channel_new function, when</pre><pre>the new channel is the main channel.</pre><pre>- channel_new is called from spice_display_constructed with the</pre><pre>list of channels that already exist; obviously, the main</pre><pre>channel is one of them.</pre><pre>- There are SpiceDisplay properties that are set during</pre><pre>construction, before spice_display_constructed is called, that</pre><pre>trigger the code I am fixing with this patch.</pre><pre><br></pre><pre>Makes sense.</pre><pre><br></pre><pre>For instance, after setting "resize-guest" to its default value</pre><pre>TRUE, update_ready is called.So I do not see how you are not</pre><pre>seeing these warnings. It does not seem to be a race condition,</pre><pre>it happens always.</pre><pre><br></pre><pre>resize-guest-enable's default is FALSE so</pre><pre>spice_main_channel_update_display_enabled() would not be called</pre><pre>and not sure how you are manage to trigger it?</pre></blockquote><div><br></div><div>My bad. We use a slightly modified version of spice-gtk for the flexVDI clients, and I did not remember that one of the changes is that resize-guest is set to TRUE by default. Maybe that's the reason we see the warning and you don't.</div></blockquote><div><br></div><div>I was thinking, maybe this patch is not needed anymore since the warning only shows in our modified version. Do you still want me to submit it? We can just keep it internally.</div></blockquote><div>IMHO is better to keep it internal if it doesn't fix any issue upstream.<br></div><div><br></div><div>Frediano</div><div><br></div></div></body></html>