<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Dec 6, 2019 at 12:18 PM Frediano Ziglio <<a href="mailto:fziglio@redhat.com">fziglio@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> <br>> +<br>
> +    if (gtk_toggle_button_get_active(toggle))<br>
> +        gtk_toggle_button_set_active(toggle, FALSE);<br>
<br>
style: always use brackets, here and below<br>
<br></blockquote><div>OK </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +    else<br>
> +        return;<br>
<br>
I would handle the return in the if to reduce indentation<br></blockquote><div>OK </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +<br>
> +    dialog = gtk_file_chooser_dialog_new(_("Select ISO file or device"),<br>
> +<br>
> GTK_WINDOW(gtk_widget_get_toplevel(GTK_WIDGET(self))),<br>
> +                                         GTK_FILE_CHOOSER_ACTION_OPEN,<br>
> +                                         _("_Cancel"), GTK_RESPONSE_CANCEL,<br>
> +                                         _("_Open"), GTK_RESPONSE_ACCEPT,<br>
> +                                         NULL);<br>
> +<br>
> +    dialog_rc = gtk_dialog_run(GTK_DIALOG(dialog));<br>
> +    if (dialog_rc == GTK_RESPONSE_ACCEPT) {<br>
> +        gchar *filename =<br>
> gtk_file_chooser_get_filename(GTK_FILE_CHOOSER(dialog));<br>
> +        GError *err = NULL;<br>
> +        gboolean rc;<br>
> +<br>
> +        rc = spice_usb_device_manager_create_shared_cd_device(priv->manager,<br>
> filename, &err);<br>
> +        if (!rc && err) {<br>
> +            gchar *err_msg = g_strdup_printf("shared CD %s, %s",<br>
> +                                             g_path_get_basename(filename),<br>
> err->message);<br>
<br>
I would add _( to string for i18n<br></blockquote><div>OK </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> +<br>
> +            SPICE_DEBUG("Failed to create %s", err_msg);<br>
> +            spice_usb_device_widget_add_err_msg(self, err_msg);<br>
> +            spice_usb_device_widget_update_status(user_data);<br>
> +        }<br>
> +        g_clear_error(&err);<br>
</blockquote><div> Similar to the previous patch</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> +    }<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> +    empty_cd = gtk_check_button_new_with_label("SPICE CD (empty)");<br>
<br>
i18n also here</blockquote><div>OK</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
>  static void spice_usb_device_widget_constructed(GObject *gobject)<br>
>  {<br>> . . . <br>
> +    priv->empty_cd = NULL;<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
This is not necessary, we don't support environment where NULL != 0 and all<br>
structure is initialized to 0 as default.<br>
And standard C decided now that NULL == 0 so no issue for the future.<br></blockquote><div>OK </div><div> </div></div></div>