<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Dec 6, 2019 at 12:06 PM Frediano Ziglio <<a href="mailto:fziglio@redhat.com">fziglio@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> <br>
> From: Alexander Nezhinsky <<a href="mailto:anezhins@redhat.com" target="_blank">anezhins@redhat.com</a>><br>> +                rc = spice_usb_device_manager_create_shared_cd_device(m,<br>
> *name, &err);<br>
> +                if (!rc) {<br>
> +                    if (!err)<br>
<br>
minor: err == NULL<br></blockquote><div>OK</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> +                        g_warning("Failed to create shared CD device %s",<br>> +                    else<br>
> +                        g_warning("Failed to create shared CD device %s:<br><br>
style: always brackets<br></blockquote><div>Sure </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
as you check for err above you can include in the else.<br></blockquote><div>OK </div></div></div>