<div dir="ltr"><div dir="ltr">Hi<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 14, 2020 at 2:32 PM Marc-André Lureau <<a href="mailto:marcandre.lureau@gmail.com">marcandre.lureau@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Hi<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 11, 2020 at 12:16 PM Marc-André Lureau <<a href="mailto:marcandre.lureau@redhat.com" target="_blank">marcandre.lureau@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
About "Move code to C++":<br>
<a href="https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62</a><br>
<br>
I would like to know how the decision happened. As long as I have been<br>
involved in the Spice project, we had open discussions and did<br>
mandatory review for anything non-trivial.<br>
<br>
This change is substantial, and impacts the work and contribution of<br>
others. Where did the discussion happen? Who reviewed the code<br>
changes?<br>
<br></blockquote><div><br></div><div>Since no real discussion nor public review took place, I propose to revert the change and add a HACKING file to make the rules clear. See:<br></div><div><br></div><div><a href="https://gitlab.freedesktop.org/spice/spice/-/merge_requests/91" target="_blank">https://gitlab.freedesktop.org/spice/spice/-/merge_requests/91</a></div></div></div></blockquote><div><br></div><div><br></div><div>I propose a spice-space page derived from libvirt "Project governance": <a href="https://gitlab.freedesktop.org/spice/spice-space-pages/-/merge_requests/18">https://gitlab.freedesktop.org/spice/spice-space-pages/-/merge_requests/18</a></div><div><br></div><div></div><div>(readable version <a href="https://gitlab.freedesktop.org/spice/spice-space-pages/-/blob/9a1907de182f9f64450a7348e9e6a1423dfa580a/governance.rst">https://gitlab.freedesktop.org/spice/spice-space-pages/-/blob/9a1907de182f9f64450a7348e9e6a1423dfa580a/governance.rst</a>)</div></div></div>