<div dir="ltr"><div>Hello spice-devel</div><div><br></div><div>I worked on the review of Frediano's C++ patches during the last weeks, <br></div><div>I tried to understand the gist of the commits and summarize it in the review message.</div><div>It's not an in-depth review, and I only spotted minor details.</div><div><br></div><div>A few patches are not acked, mostly because they were too big for me to study carefully enough.<br></div><div><br></div><div>Overall,
I really appreciate the effort made to adapt the code to C++, from my
point of view it is greatly beneficial for the code as it reduces a lot
the amount of code duplication (boilerplate code) by leveraging C++
inheritance, polymorphism, virtual methods, etc. <br></div><div>Likewise,
the ref-counting is made simpler and safer with custom classes
(share_ptr). These custom classes mimic existing ones AFAICT, but they
are more "C-safe" as they cannot throw exceptions.</div><div><br></div><div>3 mails will follow with the reviews.<br></div><div><br></div><div>Best regards,<br></div><font color="#888888"><div><br></div><div>Kevin</div></font></div>