<html><body><div style="font-family: courier new,courier,monaco,monospace,sans-serif; font-size: 12pt; color: #000000"><div>Acked the series<br></div><div><br></div><div>Frediano<br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 13, 2020 at 12:12 PM Frediano Ziglio <<a href="mailto:fziglio@redhat.com" target="_blank" data-mce-href="mailto:fziglio@redhat.com">fziglio@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left: 1px solid #cccccc; padding-left: 1ex;">> <br> > Hi,<br> > <br> > > @@ -4795,7 +4796,8 @@ NTSTATUS QxlDevice::HWClose(void)<br> > > {<br> > > PAGED_CODE();<br> > > QxlClose();<br> > > - if (m_bUefiMode)<br> > > + /* QXL device rev 5+ requires explicit reset to switch to VGA mode */<br> > > + if (m_bUefiMode || m_pQxlDod->Revision() > 4)<br> > > {<br> > > DbgPrint(TRACE_LEVEL_INFORMATION, ("%s: Resetting the device\n",<br> > > __FUNCTION__));<br> > > WRITE_PORT_UCHAR((PUCHAR)(m_IoBase + QXL_IO_RESET), 0);<br> > <br> > I'm wondering why this is conditional in the first place?<br> > Isn't it a good idea to reset the device on close no matter what?<br></blockquote><div><br></div><div>The intention was to leave the entire procedure as is where possible.</div><div>For example, when we do not use the reset, user screen resize does not happen until the BDD starts programming the VGA.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left: 1px solid #cccccc; padding-left: 1ex;">> <br> > take care,<br> > Gerd<br> > <br> <br> Surely it's less willing to cause possible regressions.<br> <br> Frediano<br> <br></blockquote></div></div></blockquote><div><br></div></div></body></html>