<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Does this patch fix an issue raised previously? Or should they be used together?<div class=""><a href="https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2466541.html" class="">https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2466541.html</a> <br class=""><div><br class=""></div><div>IMHO using this patch alone won’t fix the issue --</div><div><br class=""></div><div>Best,</div><div>- Tong</div><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 8, 2021, at 5:41 AM, Gerd Hoffmann <<a href="mailto:kraxel@redhat.com" class="">kraxel@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Specifically do not try release resources which where<br class="">not allocated in the first place.<br class=""><br class="">Cc: Tong Zhang <<a href="mailto:ztong0001@gmail.com" class="">ztong0001@gmail.com</a>><br class="">Signed-off-by: Gerd Hoffmann <<a href="mailto:kraxel@redhat.com" class="">kraxel@redhat.com</a>><br class="">---<br class=""> drivers/gpu/drm/qxl/qxl_display.c | 3 +++<br class=""> drivers/gpu/drm/qxl/qxl_kms.c | 4 ++++<br class=""> 2 files changed, 7 insertions(+)<br class=""><br class="">diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c<br class="">index c326412136c5..ec50d2cfd4e1 100644<br class="">--- a/drivers/gpu/drm/qxl/qxl_display.c<br class="">+++ b/drivers/gpu/drm/qxl/qxl_display.c<br class="">@@ -1183,6 +1183,9 @@ int qxl_destroy_monitors_object(struct qxl_device *qdev)<br class=""> {<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>int ret;<br class=""><br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>if (!qdev->monitors_config_bo)<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>return 0;<br class="">+<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>qdev->monitors_config = NULL;<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>qdev->ram_header->monitors_config = 0;<br class=""><br class="">diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c<br class="">index 66d74aaaee06..4dc5ad13f12c 100644<br class="">--- a/drivers/gpu/drm/qxl/qxl_kms.c<br class="">+++ b/drivers/gpu/drm/qxl/qxl_kms.c<br class="">@@ -288,6 +288,10 @@ void qxl_device_fini(struct qxl_device *qdev)<br class=""> {<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>int cur_idx;<br class=""><br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>/* check if qxl_device_init() was successful (gc_work is initialized last) */<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>if (!qdev->gc_work.func)<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>return;<br class="">+<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>for (cur_idx = 0; cur_idx < 3; cur_idx++) {<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>if (!qdev->current_release_bo[cur_idx])<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>continue;<br class="">-- <br class="">2.29.2<br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>