<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il giorno mar 19 apr 2022 alle ore 11:42 Victor Toso <<a href="mailto:victortoso@redhat.com">victortoso@redhat.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
On Wed, Apr 13, 2022 at 03:06:24PM +0800, Walter Mitty wrote:<br>
> Hello,<br>
> I am learning spice-server source code. And i'm confusing the 2<br>
> functions in `video-stream.cpp`: video_stream_trace_update /<br>
> video_stream_maintenance.<br>
> <br>
> There is a todo about it.<br>
> Any suggestions please?<br>
<br>
I think the TODO is also to clarify if and when functions were<br>
needed and how to properly use them. I'd need to dive into it to<br>
check. If you understand them, I'd appreciate if you submit a<br>
documentation patch about it, I'd be happy to review your<br>
findings.<br>
<br>
Cheers,<br>
Victor<br></blockquote><div><br></div><div>Hi,</div><div> I wish I had a better reply but not much.</div><div>From a quick glance one is more "focused", the other less. video_stream_trace_update is scanning all possible streams and traces looking for matches while video_stream_maintenance is looking for a single stream. Looking at callers one of the callers of video_stream_maintenance is current_add_equal which is called if another Drawable matches exactly (same position and size).<br></div><div><br></div><div>Frediano<br></div></div></div>