<div dir="ltr"><div>The procedure was:</div>We sign the driver for Win10 only and then produce 2 driver packages: one for Win 10 (with signed one) and another one for 8.1 (we call it 'compatible') as is. It is signed by RH certificate and has all the respective limitations.<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 15, 2023 at 10:44 AM Yan Vugenfirer <<a href="mailto:yvugenfi@redhat.com">yvugenfi@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Adding <a class="gmail_plusreply" id="m_8591457214490892260plusReplyChip-0" href="mailto:ybendito@redhat.com" target="_blank">@Benditovich, Yuri</a> <div><br></div><div>As far as I remember, we built qxldod for Win10 only anyway.</div><div><br></div><div>Best regards,</div><div>Yan.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 15, 2023 at 1:54 AM Vadim Rozenfeld <<a href="mailto:vrozenfe@redhat.com" target="_blank">vrozenfe@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 14, 2023 at 10:32 PM Victor Toso <<a href="mailto:victortoso@redhat.com" target="_blank">victortoso@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Freddy,<br>
<br>
On Tue, Feb 14, 2023 at 11:08:21AM +0000, Frediano Ziglio wrote:<br>
> Il giorno mar 14 feb 2023 alle ore 10:50 qi zhou <<a href="mailto:atmgnd@outlook.com" target="_blank">atmgnd@outlook.com</a>><br>
> ha scritto:<br>
> ><br>
> > > Hi,<br>
> > > It looks good to me. Why it was QXL_IO_MEMSLOT_ADD I don't know. On<br>
> > > Linux is QXL_IO_RESET too.<br>
> ><br>
> > May be a typo ?, here you can use sysinternal's notmyfault to test this bug.<br>
> > 1. launch qemu use legacy bios mode. make sure qxl driver is active, then open notmyfault64.exe click on crash button. It will trigger a bsod<br>
> > 2. without reset/patch, we cannot see bluescreen shown<br>
> ><br>
> > before qxl revision 5, even DodResetDevice does nothing, the qemu will do reset after detect qxl mode mismatch. see <a href="https://github.com/qemu/qemu/blob/ed71c09ffd6fbd01c2a487d47291ae57b08671ea/hw/display/qxl.c#L1315" rel="noreferrer" target="_blank">https://github.com/qemu/qemu/blob/ed71c09ffd6fbd01c2a487d47291ae57b08671ea/hw/display/qxl.c#L1315</a><br>
> ><br>
> > But qxl revison 5+ requires explicit reset<br>
> ><br>
> > reference:<br>
> > not myfault: <a href="https://learn.microsoft.com/en-us/sysinternals/downloads/notmyfault" rel="noreferrer" target="_blank">https://learn.microsoft.com/en-us/sysinternals/downloads/notmyfault</a><br>
> > DXGKDDI_RESET_DEVICE : <a href="https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/dispmprt/nc-dispmprt-dxgkddi_reset_device#remarks" rel="noreferrer" target="_blank">https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/dispmprt/nc-dispmprt-dxgkddi_reset_device#remarks</a><br>
> <br>
> Merged.<br>
> <br>
> Now the question is about release and build.<br>
> <br>
> Uri, Victor, should we pack a new release?<br>
<br>
I'm not sure how to release it. We used to bundle it in<br>
spice-guest-tools but there was a signing process too.<br>
<br>
I see that virtio-win also bundles spice-guest-tools so, they<br>
ship our ancient release... I see something in preinst for<br>
amd64/w8 on qxldod [0]. Vadim, does virtio-win build/sign qxldod for<br>
some Windows releases with fixes?<br>
<br></blockquote><div><br></div><div>Unfortunately qxldod is not a part of the virtio-win drivers build. </div><div>Technically, it should not be a problem to build a new version of qxldod </div><div>driver and submit it to WHQL dashboard for attestation signing. But </div><div>attestation signing works for Win10 drivers only.</div><div><br></div><div>Best,</div><div>Vadim. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
[0] <a href="https://fedorapeople.org/groups/virt/unattended/drivers/preinst/virtio-win/0.1.225/amd64/w8/" rel="noreferrer" target="_blank">https://fedorapeople.org/groups/virt/unattended/drivers/preinst/virtio-win/0.1.225/amd64/w8/</a><br>
<br>
Cheers,<br>
Victor<br>
</blockquote></div></div>
</blockquote></div>
</blockquote></div>