<div dir="ltr"><div class="gmail_quote"><div class="gmail_attr">Hi Frediano,</div><div class="gmail_attr"><br></div><div dir="ltr" class="gmail_attr">On Fri, Nov 3, 2023 at 10:59 AM Frediano Ziglio <<a href="mailto:freddy77@gmail.com">freddy77@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Avoids:<br>
<br>
WARNING: You should add the boolean check kwarg to the run_command call.<br>
It currently defaults to false,<br>
but it will default to true in future releases of meson.<br>
See also: <a href="https://github.com/mesonbuild/meson/issues/9300" rel="noreferrer" target="_blank">https://github.com/mesonbuild/meson/issues/9300</a><br>
<br>
Signed-off-by: Frediano Ziglio <<a href="mailto:freddy77@gmail.com" target="_blank">freddy77@gmail.com</a>><br></blockquote><div><br></div><div>Acked-by: Uri Lublin <<a href="mailto:uril@redhat.com">uril@redhat.com</a>></div><div><br></div><div>From a quick scan of the git repositories, there is a 'check' missing in usbredir too.</div><div><br></div><div>Thanks,</div><div> Uri.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
meson.build | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/meson.build b/meson.build<br>
index 1018769..33f8f8a 100644<br>
--- a/meson.build<br>
+++ b/meson.build<br>
@@ -132,7 +132,7 @@ if spice_common_generate_client_code or spice_common_generate_server_code<br>
if get_option('python-checks')<br>
foreach module : ['six', 'pyparsing']<br>
message('Checking for python module @0@'.format(module))<br>
- cmd = run_command(python, '-c', 'import @0@'.format(module))<br>
+ cmd = run_command(python, '-c', 'import @0@'.format(module), check : false)<br>
if cmd.returncode() != 0<br>
error('Python module @0@ not found'.format(module))<br>
endif<br>
-- <br>
2.41.0<br>
<br>
</blockquote></div></div>