From rpurdie at openedhand.com  Sun Jul 17 13:17:30 2005
From: rpurdie at openedhand.com (Richard Purdie)
Date: Sun, 17 Jul 2005 20:17:30 -0000
Subject: [Svg-icons-commit] LED devices
In-Reply-To: <1180699489.12971.6.camel@localhost.localdomain>
References: <1180524908.2573.34.camel@localhost.localdomain>
	<200705301421.09460.danny.kukawka@web.de>
	<1180528559.21970.6.camel@localhost.localdomain>
	<1180529732.5835.34.camel@localhost.localdomain>
	<1180530965.23464.14.camel@localhost.localdomain>
	<1180531884.5835.57.camel@localhost.localdomain>
	<1180533569.23464.31.camel@localhost.localdomain>
	<1180536397.5835.76.camel@localhost.localdomain>
	<1180539255.23464.69.camel@localhost.localdomain>
	<1180541971.5835.133.camel@localhost.localdomain>
	<20070531072450.GA13657@kroah.com>
	<1180684615.2556.9.camel@localhost.localdomain>
	<1180698995.6390.7.camel@localhost.localdomain>
	<1180699489.12971.6.camel@localhost.localdomain>
Message-ID: <1180700321.6390.16.camel@localhost.localdomain>

On Fri, 2007-06-01 at 13:04 +0100, Richard Hughes wrote:
> On Fri, 2007-06-01 at 12:56 +0100, Richard Purdie wrote:
> > > Richard, would you let me write a patch to fix this or are you already
> > > doing this? Thanks.
> > 
> > I'd started something, I've finished it off and added it to the LEDs
> > tree:
> > 
> > http://git.o-hand.com/?p=linux-rpurdie-leds;a=shortlog;h=for-mm
[...]
> Why not just add to the API to do:
> 
> static struct led_classdev standby_led = {
> 	.name			= "thinkpad_standby",
> 	.color			= "green",
> 	.default_trigger	= "none",
> 	.brightness_set		= led_standby_set,
> };

Several reasons:

* I want to keep the names descriptive (which is allowed afaict)
* If we remove colour from the names we break the existing API as
documented.
* Drivers should only specify the colour in one place.
* With this approach we only need to add a method to the core, not
change every LED driver.


Regards,

Richard