[Swfdec-commits] [Bug 549621] New: swfdec-gnome misuses _LDFLAGS automake variable, fails to build with --as-needed forced on

[swfdec-gnome (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=549621

  swfdec-gnome | general | Ver: 2.22.x
           Summary: swfdec-gnome misuses _LDFLAGS automake variable, fails
                    to build with --as-needed forced on
           Product: swfdec-gnome
           Version: 2.22.x
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: general
        AssignedTo: swfdec-gnome-maint at gnome.bugs
        ReportedBy: flameeyes at gentoo.org
         QAContact: swfdec-gnome-maint at gnome.bugs
     GNOME version: 2.21/2.22
   GNOME milestone: Unspecified


Please describe the problem:
The target_LDFLAGS variable in automake is designed to pass flags to the
linker, but swfdec-gnome 2.22.2 passes libraries through them, which is
non-standard.

While libtool parameter reordering makes it fine even when passing
-Wl,--as-needed through LDFLAGS, a compiler with specs modified to force
--Wl,--as-needed on, or a linker with --as-needed forced on, will refuse to
link correctly because of this.

The fix is very quick, replacing _LDFLAGS with _LIBADD.

HTH,
Diego

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=549621.