[Swfdec-commits] Branch '0.8' - 2 commits - src/plugin.c src/swfmoz_player.c
Benjamin Otte
company at kemper.freedesktop.org
Wed Sep 24 02:16:18 PDT 2008
src/plugin.c | 2 ++
src/swfmoz_player.c | 4 ----
2 files changed, 2 insertions(+), 4 deletions(-)
New commits:
commit e8f46635b702d449c27230c69f333b73a72f7b90
Author: Benjamin Otte <otte at gnome.org>
Date: Wed Sep 24 11:13:33 2008 +0200
make sure to delete initial stream if it gets destroyed
extra paranoia about flashblock behavior
diff --git a/src/plugin.c b/src/plugin.c
index 48fd413..857d733 100644
--- a/src/plugin.c
+++ b/src/plugin.c
@@ -342,6 +342,8 @@ plugin_destroy_stream_cb (NPP instance, NPStream* stream, NPReason reason)
swfmoz_loader_ensure_open (stream->pdata);
swfdec_stream_close (stream->pdata);
SWFMOZ_LOADER (stream->pdata)->stream = NULL;
+ if (SWFMOZ_PLAYER (instance->pdata)->initial == stream->pdata)
+ SWFMOZ_PLAYER (instance->pdata)->initial = NULL;
g_object_unref (stream->pdata);
return NPERR_NO_ERROR;
}
commit c37f02fc20a4ffc74eecfceeaff913a250933320
Author: Benjamin Otte <otte at gnome.org>
Date: Wed Sep 24 11:13:00 2008 +0200
SwfmozPlayer.initial is not a GObject, we must not unref it
fixes crashes caused by flashblock
diff --git a/src/swfmoz_player.c b/src/swfmoz_player.c
index 97abb89..f813748 100644
--- a/src/swfmoz_player.c
+++ b/src/swfmoz_player.c
@@ -552,10 +552,6 @@ swfmoz_player_dispose (GObject *object)
player->target = NULL;
}
swfmoz_player_clear_repaints (player);
- if (player->initial) {
- g_object_unref (player->initial);
- player->initial = NULL;
- }
if (player->loaders) {
g_object_unref (player->loaders);
player->loaders = NULL;
More information about the Swfdec-commits
mailing list