[Swfdec] [PATCH] Fix compiler warnings that prevent compilation

Pavel Roskin proski at gnu.org
Thu Oct 11 11:08:21 PDT 2007


On Thu, 2007-10-11 at 10:13 +0200, Benjamin Otte wrote:
> Thanks for the patches, we applied them, with the exception of the
> ffmpeg patch. I don't want to put workarounds for broken distro
> packages into Swfdec if I can avoid it. Those should be filed against
> the respective distros and worked around locally. And as far as I
> know, FFmpeg upstream works fine (I'm using ffmpeg svn from a month or
> so ago).

OK, thanks.  I simply fixed the headers locally.  But I'm seeing another
warning that wasn't there yesterday:

swfdec_shape_parser.c: In function 'swfdec_style_finish':
swfdec_shape_parser.c:224: warning: 'last2' may be used uninitialized in
this function
swfdec_shape_parser.c:224: warning: 'start2' may be used uninitialized
in this function

It looks like that the code is correct, but it's still seems suspicious
to gcc 4.1.2.  I would just initialize both last2 and start2 with NULL
and while at that, move cur2 declaration to the inner block where it's
used.

-- 
Regards,
Pavel Roskin



More information about the Swfdec mailing list