[Swfdec] [Bug 15960] "Done" and "Error" columns are redundant with each other

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=15960


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16697|0                           |1
        is obsolete|                            |




--- Comment #3 from Riccardo Magliocchetti <riccardo at datahost.it>  2008-05-24 04:50:23 PST ---
Created an attachment (id=16712)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16712)
 merge done and error column - try 2

(In reply to comment #2)
> You seem to be used to languages that do automatic memory management. ;)
> The return value of g_format_size_for_display() must be freed.

You are right, fixed.

> Also, I'm not sure if using red on errors is a good idea as it might look odd
> on some themes. So we'd better use something theme-agnostic, like bold, if we
> use a special marker at all.

Ok, in case of error i've removed the red color for text. 


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.