<meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr"><div>Hi,</div><div>regarding the tdepim notes issue, there was missing the link to generated sources. Unfortunately Jolla dropped the notes from Sailfish and I can only test it on the older N9 that I do not use anymore (except for testing).</div><div><br></div><div>Find attached a patch that solves this and also I added another change - initializing the TDEABC VCardConverter earlier - it can be reused later and saves time.</div><div><br></div><div>happy new year and all the best to you</div><div>regards<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Dec 17, 2020 at 1:21 PM Patrick Ohly <<a href="mailto:patrick.ohly@intel.com">patrick.ohly@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">deloptes <<a href="mailto:deloptes@gmail.com" target="_blank">deloptes@gmail.com</a>> writes:<br> > deloptes wrote:<br> ><br> >> Hi Patrik,<br> >> as you mentioned you are working on some kind of next release. I wonder if<br> >> you could add a patch or let me know how I can add it (attached).<br> >> <br> >> I found out it should not destroy here as it is being (probably) cleaned<br> >> up somewhere else. Destroying here crashes.<br> >> <br> >> I also wonder if we would be able to use openobex2 (1.7) in the new<br> >> version.<br> >> <br> >> thank you in advance<br> >> <br> >> kind regards<br> ><br> > Hmm, to me it looks like I attached some nonsense here - sorry for<br> > this :)<br> <br> And sorry for the delay with integrating this ;-) It's now in a branch<br> and getting tested (again).<br> <br> I first ran into some issue with "make dist" which I solved as follows:<br> <br> commit e489ac358b3f1c40f45d7c3c55a7a9aaea85e41f (HEAD -> master-next, tag: syncevolution-2-0-0-pre2, pohly/for-master/master-next, master-nightly-before-2020-12-17-04-10, master-nightly)<br> Author: Patrick Ohly <<a href="mailto:patrick.ohly@intel.com" target="_blank">patrick.ohly@intel.com</a>><br> Date: Thu Dec 17 03:22:07 2020 -0800<br> <br> tde: fix "make dist" issue<br> <br> "make dist" tries to include all source files in the archive, which<br> does not work for the generated files.<br> <br> diff --git a/src/backends/tdepim/<a href="http://tdepim.am" rel="noreferrer" target="_blank">tdepim.am</a> b/src/backends/tdepim/<a href="http://tdepim.am" rel="noreferrer" target="_blank">tdepim.am</a><br> index 5aace174..4c898944 100644<br> --- a/src/backends/tdepim/<a href="http://tdepim.am" rel="noreferrer" target="_blank">tdepim.am</a><br> +++ b/src/backends/tdepim/<a href="http://tdepim.am" rel="noreferrer" target="_blank">tdepim.am</a><br> @@ -38,8 +38,6 @@ if ENABLE_TDEPIMNOTES<br> src_backends_tdepim_synctdepimnotes_src += \<br> src/backends/tdepim/TDEPIMSyncSource.h \<br> src/backends/tdepim/TDEPIMSyncSource.cpp \<br> - src/backends/tdepim/KNotesIface_stub.h \<br> - src/backends/tdepim/KNotesIface_stub.cpp \<br> src/backends/tdepim/TDEPIMNotesSource.h \<br> src/backends/tdepim/TDEPIMNotesSource.cpp<br> endif<br> @@ -59,13 +57,25 @@ src/backends/tdepim/KNotesIface_stub.h: src/backends/tdepim/KNotesIface.kidl<br> <br> src/backends/tdepim/KNotesIface_stub.cpp: src/backends/tdepim/KNotesIface_stub.h<br> <br> -CLEANFILES += src/backends/tdepim/KNotesIface_stub.h \<br> +src_backends_tdepim_built_sources =<br> +src_backends_tdepim_generated =<br> +if ENABLE_TDEPIMNOTES<br> +src_backends_tdepim_built_sources += \<br> + src/backends/tdepim/KNotesIface_stub.h \<br> src/backends/tdepim/KNotesIface_stub.cpp \<br> +<br> +src_backends_tdepim_generated += \<br> + $(src_backends_tdepim_built_sources) \<br> src/backends/tdepim/KNotesIface.kidl \<br> src/backends/tdepim/KNotesIface_skel.cpp \<br> src/backends/tdepim/KNotesIface.h<br> +endif<br> +<br> +CLEANFILES += $(src_backends_tdepim_generated)<br> +BUILT_SOURCES += $(src_backends_tdepim_built_sources)<br> <br> src_backends_tdepim_synctdepimcal_la_SOURCES = $(src_backends_tdepim_synctdepimcal_src)<br> +nodist_src_backends_tdepim_synctdepimcal_la_SOURCES = $(src_backends_tdepim_built_sources)<br> src_backends_tdepim_synctdepimcal_la_LIBADD = $(TDEPIMCAL_LIBS) $(SYNCEVOLUTION_LIBS)<br> src_backends_tdepim_synctdepimcal_la_CPPFLAGS = $(TDEPIMCAL_CFLAGS) $(src_backends_tdepim_cppflags)<br> src_backends_tdepim_synctdepimcal_la_LDFLAGS = -module -avoid-version -ldl<br> <br> -- <br> Best Regards<br> <br> Patrick Ohly<br> Senior Software Engineer<br> <br> Intel GmbH<br> System Software Engineering/Cloud Native<br> Usenerstr. 5a Phone: +49-228-2493652<br> 53129 Bonn<br> Germany<br> </blockquote></div>