[systemd-bugs] [Bug 55938] New: org.freedesktop.timedate1 SetNTP should not always enable the ntpd.service

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55938

          Priority: medium
            Bug ID: 55938
          Assignee: systemd-bugs at lists.freedesktop.org
           Summary: org.freedesktop.timedate1 SetNTP should not always
                    enable the ntpd.service
        QA Contact: systemd-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: twelve.eighty at gmail.com
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: general
           Product: systemd

When using systemd, NetworkManager, NTP and then networkmanager-dispatcher-ntpd
to start NTP after NetworkManager has established a connection, the
ntpd.service service gets enabled by a call to gdbus:

gdbus call \
        --system \
        --object-path /org/freedesktop/timedate1 \
        --dest org.freedesktop.timedate1 \
        --method org.freedesktop.timedate1.SetNTP true false

The problem is that the org.freedesktop.timedate1.SetNTP method appears to
*enable* the ntpd.service and then start it. This should not be done, since in
a NetworkManager scenario, the ntpd.service should be left disabled and only
*started* when a connection is made.

The result of this bug is that upon a reboot, ntpd.service is automatically
started, BEFORE network manager creates a connection. Even after ntpd.service
is disabled again, the next time a connection is made, ntpd.service is
re-enabled.

I believe this is the problem:
http://cgit.freedesktop.org/systemd/systemd/tree/src/timedate/timedated.c

Line 871: r = enable_ntp(connection, &error);

I think that should be removed, so that only the remaining start_ntp() call is
made.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20121012/ce535195/attachment.html>