[systemd-bugs] [Bug 55213] Early boot vsnprintf/vasprintf segfault

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55213

--- Comment #2 from Zbigniew Jedrzejewski-Szmek <zbyszek at in.waw.pl> ---
I think that the analysis is correct. I don't like the posted patch though. It
is intrusive, and the formatting is done early, and the message might be
skipped afterwards.

I have a patch in the works, will post soon, taking a different approach:
va_copy(aq, ap)
vasprintf(aq, ...)
update original ap using parse_printf_format
continue with va_arg(ap, ...)

The downsides are: slight ugliness of having to update ap manually, C99
requirement for parse_printf_format.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20120924/e2987e81/attachment-0001.html>