[systemd-bugs] [Bug 67958] New: shared/util.c:get_group_creds() should not return -ESRCH upon error

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=67958

          Priority: medium
            Bug ID: 67958
          Assignee: systemd-bugs at lists.freedesktop.org
           Summary: shared/util.c:get_group_creds() should not return
                    -ESRCH upon error
        QA Contact: systemd-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: cjashfor at linux.vnet.ibm.com
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: general
           Product: systemd

get_group_creds is returning -ESRCH upon error.  The name of this error code
sounds reasonable, but the error string is "No such process".  This is a
confusing error message for looking up a user group name.

The same problem exists for the functions get_user_creds() and get_home_dir().

We ran into this error during boot-up:
systemd-journald: Failed to resolve 'systemd-journal' group:
No such process

I ended up downloading the source of systemd to see if it was talking about a
cgroup or a user group.

Instead of ESRCH, I'd suggest ENOENT.
There doesn't seem to be a perfect error code for this, but ESRCH is not a good
choice in my opinion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20130809/fdd17e56/attachment.html>