[systemd-bugs] [Bug 59621] New: configure check for -Wformat-security is broken

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59621

          Priority: medium
            Bug ID: 59621
          Assignee: systemd-bugs at lists.freedesktop.org
           Summary: configure check for -Wformat-security is broken
        QA Contact: systemd-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: chpe at gnome.org
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: general
           Product: systemd

The configure check for -Wformat-security is broken because it checks the flags
one-by-one, but -Wformat-security only works together with -Wformat:

configure:15548: checking if gcc -std=gnu99 supports flag -Wformat-security in
envvar CFLAGS
configure:15559: gcc -std=gnu99 -c -Werror -Wformat-security  conftest.c >&5
cc1: error: -Wformat-security ignored without -Wformat
[-Werror=format-security]
cc1: all warnings being treated as errors
configure:15559: $? = 1


I think this broke in commit eb2e280f9c59b66965c9316eadc4c113a13ca744 ; prior
to that commit, the flags were appended to CFLAGS directly and there is a check
for -Wformat=2 before the -Wformat-security check.

systemd is git master, gcc is gcc (GCC) 4.7.2 20120921 (Red Hat 4.7.2-2)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20130120/8e87885d/attachment.html>