[systemd-bugs] [Bug 67273] logind writes out session state file before creating fifo so users end up in CLOSING state

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=67273

Ray Strode [halfline] <rstrode at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rstrode at redhat.com

--- Comment #2 from Ray Strode [halfline] <rstrode at redhat.com> ---
Looks fine, thanks!

Two comments, but these things probably don't matter that much in practice:

1) the state file will briefly begin its life with CLOSING written in it, which
isn't really accurate, though maybe that's inconsequential.
2) you send out the reply before saving the state file, so, in theory, there's
a small race where a client could get the reply and then proceed to check the
state file and still read stale information.  It's a pretty small race though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20130726/a7b00848/attachment.html>