[systemd-bugs] [Bug 67288] console login no longer possible when PAM_SESSION_ERR condition is triggered

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=67288

--- Comment #3 from Michael Stapelberg <michael+freedesktop at stapelberg.de> ---
Some debugging revealed: With mbiebl’s patch
(http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=15;filename=pam-systemd-session-err.patch;att=1;bug=717772
), you can still log in when removing these two lines:

        if (session_fd >= 0)
                close_nointr_nofail(session_fd);

Therefore, we think what happens is that logind creates the session,
pam_systemd fails to parse the reply, closes the fd and logind kills the
session, leading to that process being killed and the login terminating.

To double-check, I used pam_debug in this way:

session optional pam_debug.so open_session=session_err

Which works fine. It’s not the return code of the module, it’s the close() of
the file descriptor.

I propose changing the code so that it won’t close the file descriptor at all.
Even though sessions will pile up and not work as expected, you will still be
able to log in, which is important. What do you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20130726/e1cee413/attachment.html>