[systemd-bugs] [Bug 67508] New: udev does not report errors properly when values are not quoted

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=67508

          Priority: medium
            Bug ID: 67508
          Assignee: systemd-bugs at lists.freedesktop.org
           Summary: udev does not report errors properly when values are
                    not quoted
        QA Contact: systemd-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: mgorny at gentoo.org
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: general
           Product: systemd

For example, consider the following rule file:

  KERNEL=="foo*", ATTR{bar}=1

The missing quoting around '1' results in udev silently ignoring the rule and
not reporting a single error. It should verbosely report a broken line instead.

falconindy nailed it down:

00:11:02       <falconindy> ah, think i found it...
00:11:26       <falconindy> mgorny:
00:11:26
http://cgit.freedesktop.org/systemd/systemd/tree/src/udev/udev-rules.c#n826
00:11:40       <falconindy> if not quoted, return -1. dun.
00:13:20       <falconindy> add_rule just needs to log the error on return from
get_key

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20130729/536cab16/attachment.html>