[systemd-bugs] [Bug 77271] systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77271

Thomas Blume <Thomas.Blume at suse.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
           Assignee|systemd-bugs at lists.freedesk |Thomas.Blume at suse.com
                   |top.org                     |
 Attachment #100789|0                           |1
        is obsolete|                            |

--- Comment #22 from Thomas Blume <Thomas.Blume at suse.com> ---
Created attachment 102974
  --> https://bugs.freedesktop.org/attachment.cgi?id=102974&action=edit
fix 0004-systemd-detect-virt-only-discover-Xen-domU.patch

The conditional for detection xen virtualization contained a little mistake.
It is checking for i to be empty: 'if (!i)  {', but it must check for cap
instead,
because: 'cap = strsep(&i, ",")' will set cap to the discovered value and i to
the next value after the separator.
Hence, i would be empty, if there is only control_d in domcap, leading to a
wrong
domU detection.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20140717/651677a6/attachment.html>