[systemd-bugs] [Bug 76744] New: core: bus_exec_context_set_transient_property: Environment transient file is totally broken in most cases

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76744

          Priority: medium
            Bug ID: 76744
          Assignee: systemd-bugs at lists.freedesktop.org
           Summary: core: bus_exec_context_set_transient_property:
                    Environment transient file is totally broken in most
                    cases
        QA Contact: systemd-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: mustrumr97 at gmail.com
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: general
           Product: systemd

In most cases the generated file will not even be valid. Example:

systemd-run --setenv 'a=b c' true

This will yield the following file:
[Service]
Environment=a=b c

Invalid environment assignment, ignoring: a=b c

--- a/src/core/dbus-execute.c
+++ b/src/core/dbus-execute.c
@@ -842,7 +842,7 @@
                         strv_free(c->environment);
                         c->environment = e;

-                        joined = strv_join(c->environment, " ");
+                        joined = strv_join_quoted(c->environment);
                         if (!joined)
                                 return -ENOMEM;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20140328/5619dcdb/attachment.html>