[systemd-bugs] [Bug 77271] systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77271

--- Comment #14 from Lennart Poettering <lennart at poettering.net> ---
Please provide a git-format-patch formatted patch.

Also, unless > 0 is returned from the call you shouldn't set *id.

Please keep variable declarations local to the block you need them in.

Checking for the feature with a simple strstr() sounds wrong, you need to check
for separators before/behind it too.

I see no reason to distuingish "xen" from "xen-domU". We probably shouldn't
consider xen-dom0 virtualization at all, and everything else should just be
"xen".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20140524/26f1db90/attachment.html>