[systemd-bugs] [Bug 90017] Improper use of asprintf() in login/pam_systemd.c

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90017

Lennart Poettering <lennart at poettering.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #1 from Lennart Poettering <lennart at poettering.net> ---
asprintf() is not POSIX anyway.

This has come up before, but I think the man page is simply a bit unlcear (I
mean, it confuses "undefined" with "whatever was set before", the code in glibc
actually doesn't clobber the pointer. 

Either way, I am pretty sure our code does this right and we should leave it
that way. SHould asprintf() in glibc really change their logic one day and
start clobbering the pointer on failure, then the right answer is to wrap
asprintf() in some call safe_asprintf() or so which fixes this behaviour.

Either way I don't think we need to fix anything now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20150414/0efd86be/attachment.html>