[systemd-bugs] [Bug 88284] New: Setting ShutdownWatchdogUSec via D-Bus does nothing

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=88284

            Bug ID: 88284
           Summary: Setting ShutdownWatchdogUSec via D-Bus does nothing
           Product: systemd
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
          Assignee: systemd-bugs at lists.freedesktop.org
          Reporter: maxtram95 at gmail.com
        QA Contact: systemd-bugs at lists.freedesktop.org

Created attachment 112081
  --> https://bugs.freedesktop.org/attachment.cgi?id=112081&action=edit
Make org.freedesktop.systemd1.Manager.ShutdownWatchdogUSec work

org.freedesktop.systemd1.Manager has a property ShutdownWatchdogUSec. I can
change it using the following command:

busctl --system set-property org.freedesktop.systemd1 /org/freedesktop/systemd1
org.freedesktop.systemd1.Manager ShutdownWatchdogUSec t 0

But it seems that this change has no effect, and systemd still uses old value
which is read from /etc/systemd/system.conf at startup.

I looked at sources:
http://cgit.freedesktop.org/systemd/systemd/tree/src/core/main.c?id=1325ec4280dd3f00f4879c5feadd524f7ba52f7e#n2014

I see that systemd uses arg_shutdown_watchdog value (the one assigned from
config file) instead of m->shutdown_watchdog (the one that user could change by
D-Bus calls). Really, we can't use m->shutdown_watchdog at that point, because
m is freed on line 1827, but we could assign arg_shutdown_watchdog =
m->shutdown_watchdog right before manager_free(m).

I suggest attached patch to fix this issue.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20150111/2d1e9587/attachment.html>