[systemd-commits] src/modules-load.c src/tmpfiles.c src/tty-ask-password-agent.c TODO

Lennart Poettering lennart at kemper.freedesktop.org
Thu Mar 3 07:30:13 PST 2011


 TODO                         |    6 ++++++
 src/modules-load.c           |    3 ++-
 src/tmpfiles.c               |    3 ++-
 src/tty-ask-password-agent.c |    3 +++
 4 files changed, 13 insertions(+), 2 deletions(-)

New commits:
commit 1a6f4df6c9437ed631080b7e006f666326063d36
Author: Lennart Poettering <lennart at poettering.net>
Date:   Thu Mar 3 16:29:50 2011 +0100

    dirent: support DT_UNKNOWN where necessary for compat with reiserfs

diff --git a/TODO b/TODO
index a7ff18a..d94cc23 100644
--- a/TODO
+++ b/TODO
@@ -24,6 +24,12 @@ F15:
 
 Features:
 
+* failure error string in "systemctl status"
+
+* send SIGCONT before SIGTERM
+
+* make sure timeouts are applied to Type=oneshot services.
+
 * maybe implement "systemctl mask" and "systemctl unmask", but not
   document it? When doing that add switch to make this temporary by
   placing mask links in /dev.
diff --git a/src/modules-load.c b/src/modules-load.c
index 3e3ccb0..2dd4326 100644
--- a/src/modules-load.c
+++ b/src/modules-load.c
@@ -43,7 +43,8 @@ static int scandir_filter(const struct dirent *d) {
                 return 0;
 
         if (d->d_type != DT_REG &&
-            d->d_type != DT_LNK)
+            d->d_type != DT_LNK &&
+            d->d_type != DT_UNKNOWN)
                 return 0;
 
         return endswith(d->d_name, ".conf");
diff --git a/src/tmpfiles.c b/src/tmpfiles.c
index 0c3b88d..68af37a 100644
--- a/src/tmpfiles.c
+++ b/src/tmpfiles.c
@@ -775,7 +775,8 @@ static int scandir_filter(const struct dirent *d) {
                 return 0;
 
         if (d->d_type != DT_REG &&
-            d->d_type != DT_LNK)
+            d->d_type != DT_LNK &&
+            d->d_type != DT_UNKNOWN)
                 return 0;
 
         return endswith(d->d_name, ".conf");
diff --git a/src/tty-ask-password-agent.c b/src/tty-ask-password-agent.c
index a9d06ac..35e4d63 100644
--- a/src/tty-ask-password-agent.c
+++ b/src/tty-ask-password-agent.c
@@ -507,6 +507,9 @@ static int show_passwords(void) {
                 int q;
                 char *wall;
 
+                /* We only support /dev on tmpfs, hence we can rely on
+                 * d_type to be reliable */
+
                 if (de->d_type != DT_REG)
                         continue;
 



More information about the systemd-commits mailing list