[systemd-commits] src/service.c

Lennart Poettering lennart at kemper.freedesktop.org
Tue Oct 11 11:23:23 PDT 2011


 src/service.c |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 1835f23c2a53e632959270e79dbf3143874e6111
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Oct 11 20:21:06 2011 +0200

    service: don't try to guess PID for SysV services anymore
    
    As it turns out there are quite a number of SysV services too broken to
    make the guessing work: instead of returning in the parent only after
    the child is fully initialized they return immediately. The effect is
    that the guessing in systemd might happen too early, at a time where the
    final main process doesn't exist yet.
    
    By turning this off we won't try to detect the main pid anymore, with
    the effect that all processes of the service in question are considered
    equally likely to be the main process.

diff --git a/src/service.c b/src/service.c
index c2053ce..e64d289 100644
--- a/src/service.c
+++ b/src/service.c
@@ -829,6 +829,7 @@ static int service_load_sysv_path(Service *s, const char *path) {
         /* Special setting for all SysV services */
         s->type = SERVICE_FORKING;
         s->remain_after_exit = !s->pid_file;
+        s->guess_main_pid = false;
         s->restart = SERVICE_RESTART_NO;
 
         if (s->meta.manager->sysv_console)



More information about the systemd-commits mailing list