[systemd-commits] src/udev

[Kay Sievers]

 src/udev/udevd.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit ef8a2bf6484bb0f82248ceb10a55509a93d82c6b
Author: Kay Sievers <kay at vrfy.org>
Date:   Mon Jul 2 20:44:05 2012 +0200

    udev: static nodes - fix default permissions if no rules is given
    
    <falconindy> kay: just curious -- it looks like nodes created by udev from
      modules.devname all have 000 perms, and there's nothing in udev that attempts
      to change this. is it intended?
    <falconindy> c---------   1 root root     10, 223 Jul  1 23:10 uinput
    <kay> falconindy: we might miss the default of 0600
    <falconindy> seems like it
    <kay> falconindy: stuff that has a rule works i guess
    <kay> falconindy: i'll add the 0600 now

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index a5478a7..393e2a9 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -845,10 +845,11 @@ static void static_dev_create_from_modules(struct udev *udev)
                 if (sscanf(devno, "%c%u:%u", &type, &maj, &min) != 3)
                         continue;
 
+                mode  = 0600;
                 if (type == 'c')
-                        mode = S_IFCHR;
+                        mode |= S_IFCHR;
                 else if (type == 'b')
-                        mode = S_IFBLK;
+                        mode |= S_IFBLK;
                 else
                         continue;