[systemd-commits] src/libudev

Kay Sievers kay at kemper.freedesktop.org
Mon Nov 12 17:03:01 PST 2012


 src/libudev/libudev-list.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit cf2292f5ac87087f57dbd632a25a332c9d194ebf
Author: Mauro Dreissig <mukadr at gmail.com>
Date:   Sun Nov 11 22:07:51 2012 -0200

    libudev: avoid leak during realloc failure

diff --git a/src/libudev/libudev-list.c b/src/libudev/libudev-list.c
index 1578aec..59ba69e 100644
--- a/src/libudev/libudev-list.c
+++ b/src/libudev/libudev-list.c
@@ -185,18 +185,20 @@ struct udev_list_entry *udev_list_entry_add(struct udev_list *list, const char *
         if (list->unique) {
                 /* allocate or enlarge sorted array if needed */
                 if (list->entries_cur >= list->entries_max) {
+                        struct udev_list_entry **entries;
                         unsigned int add;
 
                         add = list->entries_max;
                         if (add < 1)
                                 add = 64;
-                        list->entries = realloc(list->entries, (list->entries_max + add) * sizeof(struct udev_list_entry *));
-                        if (list->entries == NULL) {
+                        entries = realloc(list->entries, (list->entries_max + add) * sizeof(struct udev_list_entry *));
+                        if (entries == NULL) {
                                 free(entry->name);
                                 free(entry->value);
                                 free(entry);
                                 return NULL;
                         }
+                        list->entries = entries;
                         list->entries_max += add;
                 }
 



More information about the systemd-commits mailing list