[systemd-commits] 4 commits - TODO src/core src/journal

[Lennart Poettering]

 TODO                          |   12 ++++++++++++
 src/core/socket.c             |    2 +-
 src/journal/journald-server.c |    2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)

New commits:
commit 7d73c1343be02a59b17de0cd34375deeb815d89c
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Nov 20 00:19:27 2012 +0100

    journald: fix bad memory access
    
    https://bugzilla.redhat.com/show_bug.cgi?id=875653

diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c
index 0ff2866..3eaf0d3 100644
--- a/src/journal/journald-server.c
+++ b/src/journal/journald-server.c
@@ -336,7 +336,7 @@ void server_rotate(Server *s) {
         HASHMAP_FOREACH_KEY(f, k, s->user_journals, i) {
                 r = journal_file_rotate(&f, s->compress, s->seal);
                 if (r < 0)
-                        if (f->path)
+                        if (f)
                                 log_error("Failed to rotate %s: %s", f->path, strerror(-r));
                         else
                                 log_error("Failed to create user journal: %s", strerror(-r));

commit 10f70492aea211981e4bdbe58dd7ea110e05cd16
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Nov 20 00:19:00 2012 +0100

    socket: improve error message when we cannot spawn the socket's service unit

diff --git a/src/core/socket.c b/src/core/socket.c
index c095981..f4f40af 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -1542,7 +1542,7 @@ static void socket_enter_running(Socket *s, int cfd) {
         return;
 
 fail:
-        log_warning("%s failed to queue socket startup job: %s", UNIT(s)->id, bus_error(&error, r));
+        log_warning("%s failed to queue service startup job (Maybe the service file is missing or not a %s unit?): %s", UNIT(s)->id, cfd >= 0 ? "template" : "non-template", bus_error(&error, r));
         socket_enter_stop_pre(s, SOCKET_FAILURE_RESOURCES);
 
         if (cfd >= 0)

commit 78db35f37172f64bfc62cbb2aa364345b7cff0a3
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Nov 20 00:18:22 2012 +0100

    update TODO

diff --git a/TODO b/TODO
index d2fa011..86eea94 100644
--- a/TODO
+++ b/TODO
@@ -19,6 +19,10 @@ F18:
 
 Features:
 
+* All log messages generated from socket.c, service.c, ... should
+  include _SYSTEMD_UNIT= fields so that "systemctl status" can show
+  them along with the unit
+
 * define a message ID for "overmounting non-empty directory".
 
 * use polkit "imply" for binding hostname actions together

commit 8ed206517c2be381324ac5832bf34cc14024270e
Author: Lennart Poettering <lennart at poettering.net>
Date:   Sun Nov 18 23:32:09 2012 +0100

    update TODO

diff --git a/TODO b/TODO
index 1046ebf..d2fa011 100644
--- a/TODO
+++ b/TODO
@@ -19,8 +19,16 @@ F18:
 
 Features:
 
+* define a message ID for "overmounting non-empty directory".
+
+* use polkit "imply" for binding hostname actions together
+
+* journal: when waiting for journal additions always sleep at least 1s or so, in order to minimize wakeups
+
 * man page for catalog APIs
 
+* add catalog api for querying the raw template rather then replaced text
+
 * When shutdown.target is queued begin with an asynchronous sync()?
 
 * Add ConditionBatteryPower= or ConditionACPower=? (but definitely not both)