[systemd-commits] 3 commits - src/core src/shared TODO

[Zbigniew Jędrzejewski-Szmek]

 TODO                    |    6 ------
 src/core/dbus-manager.c |    2 +-
 src/shared/util.c       |    4 ++--
 3 files changed, 3 insertions(+), 9 deletions(-)

New commits:
commit 011afa76fb7b888a0a29e46665708c404f991e5d
Author: Martin Mikkelsen <mamikk at mamikk.no>
Date:   Thu Oct 4 14:27:29 2012 +0200

    shared: fix broken string_is_safe

diff --git a/src/shared/util.c b/src/shared/util.c
index 64d6e62..6310aec 100644
--- a/src/shared/util.c
+++ b/src/shared/util.c
@@ -5879,10 +5879,10 @@ bool string_is_safe(const char *p) {
         assert(p);
 
         for (t = p; *t; t++) {
-                if (*p < ' ')
+                if (*t < ' ')
                         return false;
 
-                if (strchr("\\\"\'", *p))
+                if (strchr("\\\"\'", *t))
                         return false;
         }
 

commit b3c2cf3d8ed6e228adb18f0701c157a01a076aeb
Author: Lukas Nykryn <lnykryn at redhat.com>
Date:   Thu Oct 4 09:49:04 2012 +0200

    dbus-manager: check return of unit_dbus_path
    
    Reply of dbus_message_new_method_return was check twice and
    path from unit_dbus_path was not.

diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c
index 8a64494..ed9784b 100644
--- a/src/core/dbus-manager.c
+++ b/src/core/dbus-manager.c
@@ -641,7 +641,7 @@ static DBusHandlerResult bus_manager_message_handler(DBusConnection *connection,
                         goto oom;
 
                 path = unit_dbus_path(u);
-                if (!reply)
+                if (!path)
                         goto oom;
 
                 if (!dbus_message_append_args(

commit 380d7cc5b7355bc6b1cafd3d93729bb9c77c5b19
Author: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Date:   Sun Oct 7 09:25:23 2012 +0200

    Shrink TODO

diff --git a/TODO b/TODO
index 486b672..848c52e 100644
--- a/TODO
+++ b/TODO
@@ -98,8 +98,6 @@ Features:
 
 * after deserializing sockets in socket.c we should reapply sockopts and things
 
-* does vasprintf advance the struct vaargs? http://pastie.org/pastes/4712773/text
-
 * do shutdown audit/utmp msgs inside of PID 1, get rid of systemd-update-utmp-runlevel
 
 * make timer units go away after they elapsed
@@ -250,8 +248,6 @@ Features:
 
 * support rd.luks.allow-discards= kernel cmdline params in cryptsetup generator
 
-* systemctl: when stopping a service which has triggres and warning about it actually check the TriggeredBy= deps fields
-
 * nspawn: make use of device cgroup contrller by default
 
 * drop accountsservice's StandardOutput=syslog and Type=dbus fields
@@ -412,8 +408,6 @@ Features:
 
 * move PAM code into its own binary
 
-* warn if the user stops a service but not its associated socket
-
 * logind: spawn user at ..service on login
 
 * logind: non-local X11 server handling