[systemd-commits] 2 commits - src/systemctl TODO

Lennart Poettering lennart at kemper.freedesktop.org
Mon Oct 15 07:35:20 PDT 2012


 TODO                      |    2 ++
 src/systemctl/systemctl.c |   10 +++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 44386fc156bfa2d623567ff7f7c8f313cfafb9bc
Author: Lukas Nykryn <lnykryn at redhat.com>
Date:   Mon Oct 15 14:51:27 2012 +0200

    systemctl: don't mangle name when it is a path
    
    systemctl enable, disable, ... can also accept full path and in this case
    we don't need to alter it.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=866346

diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index d1fbb78..7d6a6a2 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -3594,7 +3594,15 @@ static int mangle_names(char **original_names, char ***mangled_names) {
 
         i = l;
         STRV_FOREACH(name, original_names) {
-                *i = unit_name_mangle(*name);
+
+                /* When enabling units qualified path names are OK,
+                 * too, hence allow them explicitly. */
+
+                if (is_path(*name))
+                        *i = strdup(*name);
+                else
+                        *i = unit_name_mangle(*name);
+
                 if (!*i) {
                         strv_free(l);
                         return log_oom();

commit a7a3f28be404875eff20443a0fa8088bcc4c18df
Author: Lennart Poettering <lennart at poettering.net>
Date:   Mon Oct 15 16:28:04 2012 +0200

    update TODO

diff --git a/TODO b/TODO
index f3f66ff..dc5df66 100644
--- a/TODO
+++ b/TODO
@@ -19,6 +19,8 @@ F18:
 
 Features:
 
+* clean up date formatting and parsing so that all absolute/relative timestamps we format can also be parsed
+
 * _SOURCE_MONOTONIC_TIMESTAMP entries from the kernel seem to be off by 1000000
 
 * document unit_name_mangle()



More information about the systemd-commits mailing list