[systemd-commits] 2 commits - TODO src/journal

[Lennart Poettering]

 TODO                      |   13 +++++++++++--
 src/journal/journal-def.h |   15 +++++++++++----
 2 files changed, 22 insertions(+), 6 deletions(-)

New commits:
commit 0962e09ec305124d2a8dcb0269cf11c4bcdef715
Author: Lennart Poettering <lennart at poettering.net>
Date:   Sat Oct 20 17:00:57 2012 +0200

    journal: link up documentation with the file structure header

diff --git a/src/journal/journal-def.h b/src/journal/journal-def.h
index 8f00176..351eec7 100644
--- a/src/journal/journal-def.h
+++ b/src/journal/journal-def.h
@@ -27,6 +27,13 @@
 
 #include "macro.h"
 
+/*
+ * If you change this file you probably should also change its documentation:
+ *
+ * http://www.freedesktop.org/wiki/Software/systemd/journal-files
+ *
+ */
+
 typedef struct Header Header;
 
 typedef struct ObjectHeader ObjectHeader;
@@ -47,12 +54,12 @@ typedef struct FSSHeader FSSHeader;
 /* Object types */
 enum {
         OBJECT_UNUSED,
-        OBJECT_DATA,               /* !!! */
+        OBJECT_DATA,
         OBJECT_FIELD,
         OBJECT_ENTRY,
         OBJECT_DATA_HASH_TABLE,
         OBJECT_FIELD_HASH_TABLE,
-        OBJECT_ENTRY_ARRAY,        /* !!! */
+        OBJECT_ENTRY_ARRAY,
         OBJECT_TAG,
         _OBJECT_TYPE_MAX
 };
@@ -169,9 +176,9 @@ _packed_ struct Header {
         sd_id128_t seqnum_id;
         le64_t header_size;
         le64_t arena_size;
-        le64_t data_hash_table_offset;     /* for looking up data objects */
+        le64_t data_hash_table_offset;
         le64_t data_hash_table_size;
-        le64_t field_hash_table_offset;     /* for looking up field objects */
+        le64_t field_hash_table_offset;
         le64_t field_hash_table_size;
         le64_t tail_object_offset;
         le64_t n_objects;

commit 936d6fcb6c4fc8839d28f8585af6ba733a7e1a1a
Author: Lennart Poettering <lennart at poettering.net>
Date:   Sat Oct 20 17:00:29 2012 +0200

    update TODO

diff --git a/TODO b/TODO
index 371267a..eae357f 100644
--- a/TODO
+++ b/TODO
@@ -19,6 +19,17 @@ F18:
 
 Features:
 
+* journal: When interleaving journal files cache binary search results so that
+  we can cheaply continue where we left off.
+
+* journal: When used on NFS, check payload hashes
+
+* journal: When used on NFS make sure wake up sd_journal_wait() every 2s, to handle missing inotify
+
+* "See journal for details" messages should include "journalctl -u" command line
+
+* document that people can use file system ACLs to manage access to journal files, with example
+
 * don't show cgroup in "systemctl status" if empty/non-existant, especially for foreign .mount units
 
 * timedated: export boolean that clarifies whether NTP is even available
@@ -350,8 +361,6 @@ Features:
 
 * logind: add equivalent to sd_pid_get_owner_uid() to the D-Bus API
 
-* journal: API for looking for retrieving "all values of this field"
-
 * journal: deal nicely with byte-by-byte copied files, especially regards header
 
 * journal: local deserializer of export mode, http server