[systemd-commits] 3 commits - Makefile.am shell-completion/zsh

Zbigniew Jędrzejewski-Szmek zbyszek at kemper.freedesktop.org
Thu Aug 15 08:41:19 PDT 2013


 Makefile.am                           |    1 
 shell-completion/zsh/_machinectl      |    2 
 shell-completion/zsh/_systemctl       |   16 ++-
 shell-completion/zsh/_systemd         |  174 +++++++++++++++-------------------
 shell-completion/zsh/_systemd-delta   |   15 ++
 shell-completion/zsh/_systemd-inhibit |    8 +
 6 files changed, 118 insertions(+), 98 deletions(-)

New commits:
commit 24a0282324d774b2f3c7b16070015598c1665ab8
Author: William Giokas <1007380 at gmail.com>
Date:   Wed Aug 14 22:09:16 2013 -0500

    zsh_completion: Remove ctls function from _systemd
    
    The _ctls function in the main _systemd file is not needed.

diff --git a/shell-completion/zsh/_systemd b/shell-completion/zsh/_systemd
index fe39de8..e954c3e 100644
--- a/shell-completion/zsh/_systemd
+++ b/shell-completion/zsh/_systemd
@@ -1,88 +1,83 @@
 #compdef systemd-cat systemd-ask-password systemd-cgls systemd-cgtop systemd-detect-virt systemd-machine-id-setup systemd-notify systemd-tty-ask-password-agent
 
-_ctls()
-{
-    local curcontext="$curcontext" state lstate line
-    case "$service" in
-        systemd-ask-password)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--icon=[Icon name]' \
-                '--timeout=[Timeout in sec]' \
-                '--no-tty[Ask question via agent even on TTY]' \
-                '--accept-cached[Accept cached passwords]' \
-                '--multiple[List multiple passwords if available]'
-        ;;
-        systemd-cat)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--version[Show package version.]' \
-                {-t,--identifier=}'[Set syslog identifier.]' \
-                {-p,--priority=}'[Set priority value.]:value:({0..7})' \
-                '--level-prefix=[Control whether level prefix shall be parsed.]:boolean:(1 0)' \
-                ':Message'
-        ;;
-        systemd-cgls)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--version[Show package version]' \
-                '--no-pager[Do not pipe output into a pager]' \
-                {-a,--all}'[Show all groups, including empty]' \
-                '-k[Include kernel threads in output]' \
-                ':cgroups:(cpuset cpu cpuacct memory devices freezer net_cls blkio)'
-        ;;
-        systemd-cgtop)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--version[Print version and exit]' \
-                '(-c -m -i -t)-p[Order by path]' \
-                '(-c -p -m -i)-t[Order by number of tasks]' \
-                '(-m -p -i -t)-c[Order by CPU load]' \
-                '(-c -p -i -t)-m[Order by memory load]' \
-                '(-c -m -p -t)-i[Order by IO load]' \
-                {-d,--delay=}'[Specify delay]' \
-                {-n,--iterations=}'[Run for N iterations before exiting]' \
-                {-b,--batch}'[Run in batch mode, accepting no input]' \
-                '--depth=[Maximum traversal depth]'
-        ;;
-        systemd-detect-virt)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--version[Show package version]' \
-                {-c,--container}'[Only detect whether we are run in a container]' \
-                {-v,--vm}'[Only detect whether we are run in a VM]' \
-                {-q,--quiet}"[Don't output anything, just set return value]"
-        ;;
-        systemd-machine-id-setup)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--version[Show package version]'
-        ;;
-        systemd-notify)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--version[Show package version]' \
-                '--ready[Inform the init system about service start-up completion.]' \
-                '--pid=[Inform the init system about the main PID of the daemon]' \
-                '--status=[Send a free-form status string for the daemon to the init systemd]' \
-                '--booted[Returns 0 if the system was booted up with systemd]' \
-                '--readahead=[Controls disk read-ahead operations]:arguments:(cancel done noreply)'
-        ;;
-        systemd-tty-ask-password-agent)
-            _arguments \
-                {-h,--help}'[Prints a short help text and exits.]' \
-                '--version[Prints a short version string and exits.]' \
-                '--list[Lists all currently pending system password requests.]' \
-                '--query[Process all currently pending system password requests by querying the user on the calling TTY.]' \
-                '--watch[Continuously process password requests.]' \
-                '--wall[Forward password requests to wall(1).]' \
-                '--plymouth[Ask question with plymouth(8).]' \
-                '--console[Ask question on /dev/console.]'
-        ;;
-        *) _message 'eh?' ;;
-    esac
-}
-
-_ctls "$@"
+local curcontext="$curcontext" state lstate line
+case "$service" in
+    systemd-ask-password)
+        _arguments \
+            {-h,--help}'[Show this help]' \
+            '--icon=[Icon name]' \
+            '--timeout=[Timeout in sec]' \
+            '--no-tty[Ask question via agent even on TTY]' \
+            '--accept-cached[Accept cached passwords]' \
+            '--multiple[List multiple passwords if available]'
+    ;;
+    systemd-cat)
+        _arguments \
+            {-h,--help}'[Show this help]' \
+            '--version[Show package version.]' \
+            {-t,--identifier=}'[Set syslog identifier.]' \
+            {-p,--priority=}'[Set priority value.]:value:({0..7})' \
+            '--level-prefix=[Control whether level prefix shall be parsed.]:boolean:(1 0)' \
+            ':Message'
+    ;;
+    systemd-cgls)
+        _arguments \
+            {-h,--help}'[Show this help]' \
+            '--version[Show package version]' \
+            '--no-pager[Do not pipe output into a pager]' \
+            {-a,--all}'[Show all groups, including empty]' \
+            '-k[Include kernel threads in output]' \
+            ':cgroups:(cpuset cpu cpuacct memory devices freezer net_cls blkio)'
+    ;;
+    systemd-cgtop)
+        _arguments \
+            {-h,--help}'[Show this help]' \
+            '--version[Print version and exit]' \
+            '(-c -m -i -t)-p[Order by path]' \
+            '(-c -p -m -i)-t[Order by number of tasks]' \
+            '(-m -p -i -t)-c[Order by CPU load]' \
+            '(-c -p -i -t)-m[Order by memory load]' \
+            '(-c -m -p -t)-i[Order by IO load]' \
+            {-d,--delay=}'[Specify delay]' \
+            {-n,--iterations=}'[Run for N iterations before exiting]' \
+            {-b,--batch}'[Run in batch mode, accepting no input]' \
+            '--depth=[Maximum traversal depth]'
+    ;;
+    systemd-detect-virt)
+        _arguments \
+            {-h,--help}'[Show this help]' \
+            '--version[Show package version]' \
+            {-c,--container}'[Only detect whether we are run in a container]' \
+            {-v,--vm}'[Only detect whether we are run in a VM]' \
+            {-q,--quiet}"[Don't output anything, just set return value]"
+    ;;
+    systemd-machine-id-setup)
+        _arguments \
+            {-h,--help}'[Show this help]' \
+            '--version[Show package version]'
+    ;;
+    systemd-notify)
+        _arguments \
+            {-h,--help}'[Show this help]' \
+            '--version[Show package version]' \
+            '--ready[Inform the init system about service start-up completion.]' \
+            '--pid=[Inform the init system about the main PID of the daemon]' \
+            '--status=[Send a free-form status string for the daemon to the init systemd]' \
+            '--booted[Returns 0 if the system was booted up with systemd]' \
+            '--readahead=[Controls disk read-ahead operations]:arguments:(cancel done noreply)'
+    ;;
+    systemd-tty-ask-password-agent)
+        _arguments \
+            {-h,--help}'[Prints a short help text and exits.]' \
+            '--version[Prints a short version string and exits.]' \
+            '--list[Lists all currently pending system password requests.]' \
+            '--query[Process all currently pending system password requests by querying the user on the calling TTY.]' \
+            '--watch[Continuously process password requests.]' \
+            '--wall[Forward password requests to wall(1).]' \
+            '--plymouth[Ask question with plymouth(8).]' \
+            '--console[Ask question on /dev/console.]'
+    ;;
+    *) _message 'eh?' ;;
+esac
 
 #vim: set ft=zsh sw=4 ts=4 et

commit 789b904a45b98115c45fc219162772a57dae5b3e
Author: William Giokas <1007380 at gmail.com>
Date:   Wed Aug 14 22:09:15 2013 -0500

    zsh_completion: machinectl properties can be stacked

diff --git a/shell-completion/zsh/_machinectl b/shell-completion/zsh/_machinectl
index aa568e5..abdf46f 100644
--- a/shell-completion/zsh/_machinectl
+++ b/shell-completion/zsh/_machinectl
@@ -35,7 +35,7 @@
 _arguments \
   {-h,--help}'[Prints a short help text and exits.]' \
   '--version[Prints a short version string and exits.]' \
-  {-p,--property=}'[Limit output to specified property.]:property:(Name Id Timestamp TimestampMonotonic Service Scope Leader Class State RootDirectory)' \
+  \*{-p,--property=}'[Limit output to specified property.]:property:(Name Id Timestamp TimestampMonotonic Service Scope Leader Class State RootDirectory)' \
   {-a,--all}'[Show all proerties]' \
   (-l,--full)'[Do not ellipsize cgroup members]' \
   '--no-pager[Do not pipe output into a pager]' \

commit 298b9e23a6e21161a7fe486aab94944a58d5e90c
Author: William Giokas <1007380 at gmail.com>
Date:   Wed Aug 14 22:09:14 2013 -0500

    zsh_completion: Allow specifying multiple arguments
    
    Some of the options in systemd can take multiple arguments, such as
    systemctl's --type option. Previously, you would only be able to
    complete a single type after the -t, but now zsh will continue to
    complete the types, separating them by commas.
    
    systemd-inhibit's --what command has colon (:), and that has been taken
    into account.

diff --git a/Makefile.am b/Makefile.am
index 641e92f..5d35993 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -351,6 +351,7 @@ dist_zshcompletion_DATA = \
 	shell-completion/zsh/_systemd-nspawn \
 	shell-completion/zsh/_systemd-analyze \
 	shell-completion/zsh/_sd_hosts_or_user_at_host \
+	shell-completion/zsh/_systemd-delta \
 	shell-completion/zsh/_systemd
 
 dist_sysctl_DATA = \
diff --git a/shell-completion/zsh/_systemctl b/shell-completion/zsh/_systemctl
index dbe168a..cc2df3c 100644
--- a/shell-completion/zsh/_systemctl
+++ b/shell-completion/zsh/_systemctl
@@ -294,11 +294,23 @@ _outputmodes() {
     _describe -t output 'output mode' _output_opts || compadd "$@"
 }
 
+_unit_states() {
+    local -a _states
+    _states=(loaded failed active inactive not-found listening running waiting plugged mounted exited dead masked)
+    _values -s , "${_states[@]}"
+}
+
+_unit_types() {
+    local -a _types
+    _types=(automount device mount path service snapshot socket swap target timer)
+    _values -s , "${_types[@]}"
+}
+
 _arguments -s \
     {-h,--help}'[Show help]' \
     '--version[Show package version]' \
-    {-t,--type=}'[List only units of a particular type]:unit type:(automount device mount path service snapshot socket swap target timer)' \
-    '--state=[Display units in the specified state]:unit state:(loaded failed active inactive not-found listening running waiting plugged mounted exited dead masked)' \
+    {-t,--type=}'[List only units of a particular type]:unit type:_unit_types' \
+    '--state=[Display units in the specifyied state]:unit state:_unit_states' \
     \*{-p,--property=}'[Show only properties by specific name]:unit property' \
     {-a,--all}'[Show all units/properties, including dead/empty ones]' \
     '--reverse[Show reverse dependencies]' \
diff --git a/shell-completion/zsh/_systemd b/shell-completion/zsh/_systemd
index 7aab52d..fe39de8 100644
--- a/shell-completion/zsh/_systemd
+++ b/shell-completion/zsh/_systemd
@@ -1,4 +1,4 @@
-#compdef systemd-cat systemd-ask-password systemd-cgls systemd-cgtop systemd-delta systemd-detect-virt systemd-machine-id-setup systemd-notify systemd-tty-ask-password-agent
+#compdef systemd-cat systemd-ask-password systemd-cgls systemd-cgtop systemd-detect-virt systemd-machine-id-setup systemd-notify systemd-tty-ask-password-agent
 
 _ctls()
 {
@@ -45,15 +45,6 @@ _ctls()
                 {-b,--batch}'[Run in batch mode, accepting no input]' \
                 '--depth=[Maximum traversal depth]'
         ;;
-        systemd-delta)
-            _arguments \
-                {-h,--help}'[Show this help]' \
-                '--version[Show package version]' \
-                '--no-pager[Do not pipe output into a pager]' \
-                '--diff=[Show a diff when overridden files differ]:boolean:(1 0)' \
-                {-t,--type=}'[Only display a selected set of override types]:types:(masked equivalent redirected overridden unchanged)' \
-                ':SUFFIX:(tmpfiles.d sysctl.d systemd/system)'
-        ;;
         systemd-detect-virt)
             _arguments \
                 {-h,--help}'[Show this help]' \
diff --git a/shell-completion/zsh/_systemd-delta b/shell-completion/zsh/_systemd-delta
new file mode 100644
index 0000000..6abb6fc
--- /dev/null
+++ b/shell-completion/zsh/_systemd-delta
@@ -0,0 +1,15 @@
+#compdef systemd-delta
+
+_delta_type() {
+    local -a _delta_types
+    _delta_types=(masked equivalent redirected overridden unchanged)
+    _values -s , "${_delta_types[@]}"
+}
+
+_arguments \
+    {-h,--help}'[Show this help]' \
+    '--version[Show package version]' \
+    '--no-pager[Do not pipe output into a pager]' \
+    '--diff=[Show a diff when overridden files differ]:boolean:(1 0)' \
+    {-t,--type=}'[Only display a selected set of override types]:types:_delta_type' \
+    ':SUFFIX:(tmpfiles.d sysctl.d systemd/system)'
diff --git a/shell-completion/zsh/_systemd-inhibit b/shell-completion/zsh/_systemd-inhibit
index 7953455..1ecb6dc 100644
--- a/shell-completion/zsh/_systemd-inhibit
+++ b/shell-completion/zsh/_systemd-inhibit
@@ -16,10 +16,16 @@ _systemd_inhibit_command(){
     fi
 }
 
+_inhibit_what() {
+    local _inhibit
+    _inhibit=(shutdown sleep idle handle-power-key handle-suspend-key handle-hibernate-key handle-lid-switch)
+    _values -s : "${_inhibit[@]}"
+}
+
 _arguments \
     {-h,--help}'[Show this help]' \
     '--version[Show package version]' \
-    '--what=[Operations to inhibit]:options:(shutdown sleep idle handle-power-key handle-suspend-key handle-hibernate-key handle-lid-switch)' \
+    '--what=[Operations to inhibit]:options:_inhibit_what' \
     '--who=[A descriptive string who is inhibiting]' \
     '--why=[A descriptive string why is being inhibited]' \
     '--mode=[One of block or delay]' \



More information about the systemd-commits mailing list