[systemd-commits] src/core TODO

Kay Sievers kay at kemper.freedesktop.org
Tue Dec 17 20:08:16 PST 2013


 TODO              |    8 ++++++++
 src/core/device.c |    4 ++++
 2 files changed, 12 insertions(+)

New commits:
commit 48b9cfcb7cfbcd7ab16cae809ebda32be77366bd
Author: Kay Sievers <kay at vrfy.org>
Date:   Wed Dec 18 05:06:32 2013 +0100

    comment out udev's is_initialized call until the problem is sorted out

diff --git a/TODO b/TODO
index 8025169..8960089 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,12 @@
 Bugfixes:
+* sort-out libudev's is_initialized logic for:
+  - enumerate devices:
+    - is_initialized is true if a database exists
+  - monitor devices:
+    - is_initialized is always false; was not supposed to be used here
+  - in-container devices:
+    - is_initialized is always false, because there is no database
+
 * enabling an instance unit creates a pointless link, and
   the unit will be started with getty at getty.service:
     $ systemctl enable getty at .service
diff --git a/src/core/device.c b/src/core/device.c
index 70fac1b..c93c947 100644
--- a/src/core/device.c
+++ b/src/core/device.c
@@ -303,9 +303,13 @@ static int device_process_new_device(Manager *m, struct udev_device *dev) {
 
         assert(m);
 
+#if 0
+        /* FIXME: this is always false for devices received from udev_monitor */
+
         /* Don't pick up devices before udev finished initialization for them */
         if (!udev_device_get_is_initialized(dev))
                 return 0;
+#endif
 
         sysfs = udev_device_get_syspath(dev);
         if (!sysfs)



More information about the systemd-commits mailing list