[systemd-commits] TODO src/login

[Lennart Poettering]

 TODO                       |    3 ---
 src/login/71-seat.rules.in |    2 +-
 src/login/logind.c         |    4 ++--
 src/login/sysfs-show.c     |    2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

New commits:
commit 2d96536dd7ef371c94be70cd9fb0fcbc0e5a0329
Author: Lennart Poettering <lennart at poettering.net>
Date:   Sat Feb 9 01:25:55 2013 +0100

    logind: rename "seat-master" tag to "master-of-seat"
    
    We currently enforce that seats are to be named in the form of
    "seatXXX", i.e. need to begin with the 4 characters "seat". Thus,
    "seat-master" would qualify as a seat name. As seat names are frequently
    used as tags on devices, the "seat-master" tag might hence confuse
    logind if the user decides to name a seat "seat-master".
    
    Hence, avoid any ambuigity: let's rename the "seat-master" tag to
    "master-of-seat".

diff --git a/TODO b/TODO
index d373150..d195137 100644
--- a/TODO
+++ b/TODO
@@ -49,9 +49,6 @@ Fedora 19:
   - localectl: add listing support for X11 keymaps, by parsing /usr/share/X11/xkb/rules/xorg.lst
   - localectl: support new converted x11→console keymaps
 
-* The tag "seat-master" in udev is badly named, as it might conflict with
-  actual seat names.
-
 * logind: Class property should probably know "background" or so as value for cron jobs, and the inhibition checks should filter those out too.
 
 * We should not set KDSKBMODE to K_UNICODE in vconsole-setup if the
diff --git a/src/login/71-seat.rules.in b/src/login/71-seat.rules.in
index 4f1a9a5..a064de4 100644
--- a/src/login/71-seat.rules.in
+++ b/src/login/71-seat.rules.in
@@ -10,7 +10,7 @@ ACTION=="remove", GOTO="seat_end"
 TAG=="uaccess", SUBSYSTEM!="sound", TAG+="seat"
 SUBSYSTEM=="sound", KERNEL=="card*", TAG+="seat"
 SUBSYSTEM=="input", KERNEL=="input*", TAG+="seat"
-SUBSYSTEM=="graphics", KERNEL=="fb[0-9]*", TAG+="seat", TAG+="seat-master"
+SUBSYSTEM=="graphics", KERNEL=="fb[0-9]*", TAG+="seat", TAG+="master-of-seat"
 SUBSYSTEM=="usb", ATTR{bDeviceClass}=="09", TAG+="seat"
 
 # 'Plugable' USB hub, sound, network, graphics adapter
diff --git a/src/login/logind.c b/src/login/logind.c
index be793e2..680bc1f 100644
--- a/src/login/logind.c
+++ b/src/login/logind.c
@@ -461,7 +461,7 @@ int manager_enumerate_devices(Manager *m) {
                 goto finish;
         }
 
-        r = udev_enumerate_add_match_tag(e, "seat-master");
+        r = udev_enumerate_add_match_tag(e, "master-of-seat");
         if (r < 0)
                 goto finish;
 
@@ -1293,7 +1293,7 @@ static int manager_connect_udev(Manager *m) {
         if (!m->udev_seat_monitor)
                 return -ENOMEM;
 
-        r = udev_monitor_filter_add_match_tag(m->udev_seat_monitor, "seat-master");
+        r = udev_monitor_filter_add_match_tag(m->udev_seat_monitor, "master-of-seat");
         if (r < 0)
                 return r;
 
diff --git a/src/login/sysfs-show.c b/src/login/sysfs-show.c
index fc3af75..3c03bd1 100644
--- a/src/login/sysfs-show.c
+++ b/src/login/sysfs-show.c
@@ -68,7 +68,7 @@ static int show_sysfs_one(
                         continue;
                 }
 
-                is_master = udev_device_has_tag(d, "seat-master");
+                is_master = udev_device_has_tag(d, "master-of-seat");
 
                 name = udev_device_get_sysattr_value(d, "name");
                 if (!name)