[systemd-commits] 2 commits - TODO src/core

[Lennart Poettering]

 TODO                      |    4 ++++
 src/core/selinux-access.c |   13 +++++++++----
 2 files changed, 13 insertions(+), 4 deletions(-)

New commits:
commit cbb7712189527f9f483321607e44c4ead3dd11b8
Author: Lennart Poettering <lennart at poettering.net>
Date:   Wed Feb 13 19:35:28 2013 +0100

    TODO

diff --git a/TODO b/TODO
index 7f77605..d1b85a9 100644
--- a/TODO
+++ b/TODO
@@ -56,6 +56,10 @@ Fedora 19:
 
 Features:
 
+* use "log level" rather than "log priority" everywhere
+
+* unit_name_mangle() is currently not used on "systemctl enable" and friends, only on "systemctl start"
+
 * ensure sd_journal_seek_monotonic actually works properly.
 
 * timedate: have global on/off switches for auto-time (NTP), and auto-timezone that connman can subscribe to.

commit ace188cf3a0de77cb644f0e4dee7853c4f6404fd
Author: Lennart Poettering <lennart at poettering.net>
Date:   Wed Feb 13 19:35:08 2013 +0100

    selinux: use a dynamically sized string when generating audit messages
    
    https://bugzilla.redhat.com/show_bug.cgi?id=883043

diff --git a/src/core/selinux-access.c b/src/core/selinux-access.c
index 08a4834..bc195f3 100644
--- a/src/core/selinux-access.c
+++ b/src/core/selinux-access.c
@@ -181,13 +181,18 @@ static int log_callback(int type, const char *fmt, ...) {
 
 #ifdef HAVE_AUDIT
         if (get_audit_fd() >= 0) {
-                char buf[LINE_MAX];
+                _cleanup_free_ char *buf = NULL;
+                int r;
 
-                vsnprintf(buf, sizeof(buf), fmt, ap);
-                audit_log_user_avc_message(get_audit_fd(), AUDIT_USER_AVC, buf, NULL, NULL, NULL, 0);
+                r = vasprintf(&buf, fmt, ap);
                 va_end(ap);
 
-                return 0;
+                if (r >= 0) {
+                        audit_log_user_avc_message(get_audit_fd(), AUDIT_USER_AVC, buf, NULL, NULL, NULL, 0);
+                        return 0;
+                }
+
+                va_start(ap, fmt);
         }
 #endif
         log_metav(LOG_USER | LOG_INFO, __FILE__, __LINE__, __FUNCTION__, fmt, ap);