[systemd-commits] 3 commits - TODO src/core src/login

[Lennart Poettering]

 TODO                       |    4 ++++
 src/core/job.c             |    2 +-
 src/login/logind-session.c |    3 +--
 3 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 8e417f59b668b1e5cbf6c1ff305595a6ffe56fba
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Jan 15 20:50:18 2013 +0100

    update TODO

diff --git a/TODO b/TODO
index 4704604..7338e08 100644
--- a/TODO
+++ b/TODO
@@ -19,6 +19,10 @@ F18:
 
 Features:
 
+* logind: make PrepareForSuspend(false) an official api for notification of resumes
+
+* ExecStartPre= with an empty string should reset the list of commands to invoke
+
 * refuse instantiation of proc.mount and mount units for all other API fs
 
 * "systemctl disable" on a static unit prints no message and does

commit 0762eaa3272b8c6d900737d610c9314c8610ef75
Author: Michal Sekletar <msekleta at redhat.com>
Date:   Fri Jan 11 17:06:23 2013 +0100

    logind: remove unused variable

diff --git a/src/login/logind-session.c b/src/login/logind-session.c
index b64a5d3..b981e14 100644
--- a/src/login/logind-session.c
+++ b/src/login/logind-session.c
@@ -772,7 +772,6 @@ static int get_process_ctty_atime(pid_t pid, usec_t *atime) {
 }
 
 int session_get_idle_hint(Session *s, dual_timestamp *t) {
-        _cleanup_free_ char *p = NULL;
         usec_t atime = 0, n;
         int r;
 
@@ -786,7 +785,7 @@ int session_get_idle_hint(Session *s, dual_timestamp *t) {
                 return s->idle_hint;
         }
 
-        /* Graphical sessions really should really implement a real
+        /* Graphical sessions should really implement a real
          * idle hint logic */
         if (s->display)
                 goto dont_know;

commit 38c888a4049438f2521edf38d55f937b53d17a9e
Author: Michal Sekletar <msekleta at redhat.com>
Date:   Fri Jan 11 17:06:22 2013 +0100

    core: use correct argument of type JobResult

diff --git a/src/core/job.c b/src/core/job.c
index 5ff95f5..31ab118 100644
--- a/src/core/job.c
+++ b/src/core/job.c
@@ -821,7 +821,7 @@ int job_finish_and_invalidate(Job *j, JobResult result, bool recursive) {
                 log_struct(LOG_NOTICE,
                            "UNIT=%s", u->id,
                            "JOB_TYPE=%s", job_type_to_string(t),
-                           "JOB_RESULT=%s", job_result_to_string(t),
+                           "JOB_RESULT=%s", job_result_to_string(result),
                            "Job %s/%s failed with result '%s'.",
                            u->id,
                            job_type_to_string(t),