[systemd-commits] 2 commits - src/udev TODO

[Kay Sievers]

 TODO                           |   26 ++++++++++----------------
 src/udev/udev-builtin-net_id.c |    7 +++++--
 2 files changed, 15 insertions(+), 18 deletions(-)

New commits:
commit abd55b16547d0bb0ed1c31e72e16838f0f59f48b
Author: Kay Sievers <kay at vrfy.org>
Date:   Thu Jan 17 03:30:55 2013 +0100

    TODO: update udev

diff --git a/TODO b/TODO
index d91eb36..c948d89 100644
--- a/TODO
+++ b/TODO
@@ -42,8 +42,6 @@ Features:
 
 * mount: turn dependency information from /proc/self/mountinfo into dependency information between systemd units.
 
-* udev: remove all (misguided from day 1) userspace firmware_class handling
-
 * logind: optionally, ignore idle-hint logic for autosuspend, block suspend as long as a session is around
 
 * service: when killing a service with SIGKILL always kill all processes, even if for SIGTERM we only killed the main process
@@ -104,8 +102,6 @@ Features:
 * hwdb:
   - implement conditional properties (dmi matches)
   - hwdb --filter=ID_DRIVE_*
-  - find out what to do for blockdevs and skipping scsi modaliases
-  - move writing code to src/libudev/libudev-hwdb-private.c
 
 * if booted in "quiet" mode, and an error happens, turn on status output again, so that the emergency mode isn't totally surprising
 
@@ -385,8 +381,6 @@ Features:
 
 * don't delete /tmp/systemd-namespace-* before a process is gone down
 
-* vconsole: implement setterm -store -foreground xxx --background zzz
-
 * ExecOnFailure=/usr/bin/foo
 
 * fedora: make sshd and pam_loginuid work in nspawn containers
@@ -397,16 +391,16 @@ Features:
 
 * ConditionSecurity= should learn about IMA and SMACK
 
-* udev: move to LGPL
-
-* udev systemd unify:
-  - utf8 validator code
-
-* udev: scsi_id -> sg3_utils -> kill scsi_id
-
-* udev: add trigger --subsystem-match=usb/usb_device device
+* udev:
+  - remove all (misguided from day 1) userspace firmware_class handling
+  - move to LGPL
+  - unify utf8 validator code with shared/
+  - kill scsi_id
+  - add trigger --subsystem-match=usb/usb_device device
 
-* allow configuration of console width/height in vconsole.conf
+* vconsole:
+  - implement setterm -store -foreground xxx --background zzz
+  - allow configuration of console width/height in vconsole.conf
 
 * cleanup syslog 'priority' vs. 'level' wording
 
@@ -436,7 +430,7 @@ Features:
 
 * figure out whether we should leave dbus around during shutdown
 
-* dbus: in fedora, make the machine a symlink to /etc/machine-id
+* dbus: in fedora, make /var/lib/dbus/machine-id a symlink to /etc/machine-id
 
 * dbus: move dbus to early boot
 

commit f4ddacbd4de0f159ec598f8ad690466a84787ec5
Author: Kay Sievers <kay at vrfy.org>
Date:   Thu Jan 17 03:30:07 2013 +0100

    udev: net_id - suppress bcma core == 0

diff --git a/src/udev/udev-builtin-net_id.c b/src/udev/udev-builtin-net_id.c
index 312a54a..20d96e0 100644
--- a/src/udev/udev-builtin-net_id.c
+++ b/src/udev/udev-builtin-net_id.c
@@ -327,10 +327,13 @@ static int names_bcma(struct udev_device *dev, struct netnames *names) {
         if (!bcmadev)
                 return -ENOENT;
 
-        /* bus num, core num */
+        /* bus num:core num */
         if (sscanf(udev_device_get_sysname(bcmadev), "bcma%*d:%d", &core) != 1)
                 return -EINVAL;
-        snprintf(names->bcma_core, sizeof(names->bcma_core), "b%d", core);
+        /* suppress the common core == 0 */
+        if (core > 0)
+                snprintf(names->bcma_core, sizeof(names->bcma_core), "b%d", core);
+
         names->type = NET_BCMA;
         return 0;
 }