[systemd-commits] src/libsystemd-bus TODO

[Kay Sievers]

 TODO                              |    1 +
 src/libsystemd-bus/bus-internal.c |   10 ++++++++++
 src/libsystemd-bus/bus-internal.h |    1 +
 src/libsystemd-bus/bus-message.c  |    4 ++--
 4 files changed, 14 insertions(+), 2 deletions(-)

New commits:
commit dbb642afae6aa825594fb1c57dff632b013666a3
Author: Kay Sievers <kay at vrfy.org>
Date:   Sat Nov 9 00:58:11 2013 +0100

    bus: let magic ":no-sender" pass the validation

diff --git a/TODO b/TODO
index 38246f6..b5ffbb2 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,5 @@
 Bugfixes:
+* check :no-sender logic after PID conversion
 
 * enabling an instance unit creates a pointless link, and
   the unit will be started with getty at getty.service:
diff --git a/src/libsystemd-bus/bus-internal.c b/src/libsystemd-bus/bus-internal.c
index 0bea8ca..f0a28c6 100644
--- a/src/libsystemd-bus/bus-internal.c
+++ b/src/libsystemd-bus/bus-internal.c
@@ -166,6 +166,16 @@ bool service_name_is_valid(const char *p) {
         return true;
 }
 
+bool sender_name_is_valid(const char *p) {
+        if (isempty(p))
+                return false;
+
+        if (streq(p, ":no-sender"))
+                return true;
+
+        return service_name_is_valid(p);
+}
+
 bool member_name_is_valid(const char *p) {
         const char *q;
 
diff --git a/src/libsystemd-bus/bus-internal.h b/src/libsystemd-bus/bus-internal.h
index 5fc3a24..cd9f37e 100644
--- a/src/libsystemd-bus/bus-internal.h
+++ b/src/libsystemd-bus/bus-internal.h
@@ -271,6 +271,7 @@ struct sd_bus {
 
 bool interface_name_is_valid(const char *p);
 bool service_name_is_valid(const char *p);
+bool sender_name_is_valid(const char *p);
 bool member_name_is_valid(const char *p);
 bool object_path_is_valid(const char *p);
 char *object_path_startswith(const char *a, const char *b);
diff --git a/src/libsystemd-bus/bus-message.c b/src/libsystemd-bus/bus-message.c
index 42c764c..2c2e69e 100644
--- a/src/libsystemd-bus/bus-message.c
+++ b/src/libsystemd-bus/bus-message.c
@@ -3928,7 +3928,7 @@ int bus_message_parse_fields(sd_bus_message *m) {
                         if (!streq(signature, "s"))
                                 return -EBADMSG;
 
-                        r = message_peek_field_string(m, service_name_is_valid, &ri, &m->destination);
+                        r = message_peek_field_string(m, sender_name_is_valid, &ri, &m->destination);
                         break;
 
                 case SD_BUS_MESSAGE_HEADER_SENDER:
@@ -3939,7 +3939,7 @@ int bus_message_parse_fields(sd_bus_message *m) {
                         if (!streq(signature, "s"))
                                 return -EBADMSG;
 
-                        r = message_peek_field_string(m, service_name_is_valid, &ri, &m->sender);
+                        r = message_peek_field_string(m, sender_name_is_valid, &ri, &m->sender);
                         break;