[systemd-commits] 4 commits - catalog/systemd-fr.catalog catalog/systemd-ru.catalog configure.ac Makefile.am po/.gitignore po/LINGUAS po/ru.po

[Lennart Poettering]

On Thu, 28.11.13 00:54, Zbigniew Jędrzejewski-Szmek (zbyszek at kemper.freedesktop.org) wrote:

> commit f1a1264d13b31b9f5521f482d9a5a9d78da55efb
> Author: Zbigniew J??drzejewski-Szmek <zbyszek at in.waw.pl>
> Date:   Thu Nov 28 03:41:33 2013 -0500
> 
>     build-sys: avoid warnings from assert_cc
> 
> diff --git a/configure.ac b/configure.ac
> index c0656f4..f1b00c5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -128,7 +128,6 @@ CC_CHECK_FLAGS_APPEND([with_cflags], [CFLAGS], [\
>          -Wold-style-definition \
>          -Wpointer-arith \
>          -Winit-self \
> -        -Wdeclaration-after-statement \
>          -Wfloat-equal \
>          -Wmissing-prototypes \
>          -Wstrict-prototypes \
> 

I reverted this bit. Newer GCC versions don't suffer by this problem,
and I think the warning makes a lot of sense on those.

Instead we should add some code to macro.h which turns off the the
warning with the #pragma stuff only if it detects it is being run on an
old gcc.

I would have just added this on my own, but I can't test this, since my
gcc is new enough to not need this.

gcc 4.8.2 (which is what Fedora 20 is using) works fine. So I would
suggest some ifdef check in macro.h that uses #pragma to globally turn
off the warning if anything < 4.8.2 i used...

Lennart

-- 
Lennart Poettering, Red Hat