[systemd-commits] 2 commits - TODO src/libsystemd-bus

[Lennart Poettering]

 TODO                                |    9 +++------
 src/libsystemd-bus/bus-error.c      |    4 ++--
 src/libsystemd-bus/test-bus-error.c |   10 +++++-----
 3 files changed, 10 insertions(+), 13 deletions(-)

New commits:
commit 4734b895641bd1cfb47b2eb62b0ce3f2565aa578
Author: Lennart Poettering <lennart at poettering.net>
Date:   Sat Nov 30 19:55:23 2013 +0100

    update TODO

diff --git a/TODO b/TODO
index ff162ea..65b11c7 100644
--- a/TODO
+++ b/TODO
@@ -121,14 +121,8 @@ Features:
   - implement translator service
   - implement busname unit type in systemd
   - move to gvariant
-  - synthesize sd_bus_message objects from kernel messages
-  - properly implement name registry ioctls for kdbus
   - implement monitor logic
   - properly map matches with well-known names against messages with unique names
-  - longer term:
-    * priority queues
-    * priority inheritance
-  - synthesized messages should get serial number (uint32_t) -1
   - when triggering property change events, allow a NULL strv indicate that all properties listed as such are send out as changed
   - enforce signatures on response messages
   - see if we can drop more message validation on the sending side
@@ -136,6 +130,9 @@ Features:
   - add API to clone sd_bus_message objects
   - SD_BUS_COMMENT() macro for inclusion in vtables, syntax inspired by gdbus
   - unelss configure option is specified refuse connecting and creating kdbus, so that we can break compat
+  - longer term:
+    * priority queues
+    * priority inheritance
 
 * sd-event
   - allow multiple signal handlers per signal

commit 763e20e675799e9c8d8b62857cdd01126b62e9a9
Author: Lennart Poettering <lennart at poettering.net>
Date:   Sat Nov 30 19:53:33 2013 +0100

    bus: use "System.Error." as prefix for implicit errno bus errors
    
    We probably shouldn't use "Posix.Error" since many of the errors have
    nothing to do with Posix.

diff --git a/src/libsystemd-bus/bus-error.c b/src/libsystemd-bus/bus-error.c
index 45dff80..25eaf0e 100644
--- a/src/libsystemd-bus/bus-error.c
+++ b/src/libsystemd-bus/bus-error.c
@@ -42,7 +42,7 @@ static int bus_error_name_to_errno(const char *name) {
         if (!name)
                 return EINVAL;
 
-        p = startswith(name, "Posix.Error.");
+        p = startswith(name, "System.Error.");
         if (p) {
                 r = errno_from_name(p);
                 if (r <= 0)
@@ -198,7 +198,7 @@ static int errno_to_bus_error_name_new(int error, char **ret) {
         if (!name)
                 return 0;
 
-        n = strappend("Posix.Error.", name);
+        n = strappend("System.Error.", name);
         if (!n)
                 return -ENOMEM;
 
diff --git a/src/libsystemd-bus/test-bus-error.c b/src/libsystemd-bus/test-bus-error.c
index 16c75a3..b78be54 100644
--- a/src/libsystemd-bus/test-bus-error.c
+++ b/src/libsystemd-bus/test-bus-error.c
@@ -86,19 +86,19 @@ int main(int argc, char *argv[]) {
         assert_se(sd_bus_error_is_set(&second));
 
         assert_se(!sd_bus_error_is_set(&error));
-        assert_se(sd_bus_error_set_const(&error, "Posix.Error.EUCLEAN", "Hallo") == -EUCLEAN);
-        assert_se(streq(error.name, "Posix.Error.EUCLEAN"));
+        assert_se(sd_bus_error_set_const(&error, "System.Error.EUCLEAN", "Hallo") == -EUCLEAN);
+        assert_se(streq(error.name, "System.Error.EUCLEAN"));
         assert_se(streq(error.message, "Hallo"));
-        assert_se(sd_bus_error_has_name(&error, "Posix.Error.EUCLEAN"));
+        assert_se(sd_bus_error_has_name(&error, "System.Error.EUCLEAN"));
         assert_se(sd_bus_error_get_errno(&error) == EUCLEAN);
         assert_se(sd_bus_error_is_set(&error));
         sd_bus_error_free(&error);
 
         assert_se(!sd_bus_error_is_set(&error));
         assert_se(sd_bus_error_set_errno(&error, EBUSY) == -EBUSY);
-        assert_se(streq(error.name, "Posix.Error.EBUSY"));
+        assert_se(streq(error.name, "System.Error.EBUSY"));
         assert_se(streq(error.message, strerror(EBUSY)));
-        assert_se(sd_bus_error_has_name(&error, "Posix.Error.EBUSY"));
+        assert_se(sd_bus_error_has_name(&error, "System.Error.EBUSY"));
         assert_se(sd_bus_error_get_errno(&error) == EBUSY);
         assert_se(sd_bus_error_is_set(&error));
         sd_bus_error_free(&error);