[systemd-commits] src/core

Lennart Poettering lennart at kemper.freedesktop.org
Thu Aug 21 08:35:23 PDT 2014


 src/core/execute.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit f461c8073dee9cd10bfae5ae3586e785ec8a5d07
Author: Lennart Poettering <lennart at poettering.net>
Date:   Thu Aug 21 17:35:19 2014 +0200

    execute: explain in a comment, why close_all_fds() is invoked the second time differently

diff --git a/src/core/execute.c b/src/core/execute.c
index 2544a24..b5b2247 100644
--- a/src/core/execute.c
+++ b/src/core/execute.c
@@ -1635,7 +1635,9 @@ int exec_spawn(ExecCommand *command,
                 }
 
                 /* We repeat the fd closing here, to make sure that
-                 * nothing is leaked from the PAM modules */
+                 * nothing is leaked from the PAM modules. Note that
+                 * we are more aggressive this time since socket_fd
+                 * and the netns fds we don#t need anymore. */
                 err = close_all_fds(fds, n_fds);
                 if (err >= 0)
                         err = shift_fds(fds, n_fds);



More information about the systemd-commits mailing list